Making Ingress optional

[prometherion]

A Tenant Control Plane backed by an Ingress can be deployed with the following YAML definition:

apiVersion: kamaji.clastix.io/v1alpha1
kind: TenantControlPlane
metadata:
  name: test
spec:
  controlPlane:
    deployment:
      replicas: 2
      additionalMetadata:
        annotations:
          environment.clastix.io: test
          tier.clastix.io: "0"
        labels:
          tenant.clastix.io: test
          kind.clastix.io: deployment
    service:
      additionalMetadata:
        annotations:
          environment.clastix.io: test
          tier.clastix.io: "0"
        labels:
          tenant.clastix.io: test
          kind.clastix.io: service
      serviceType: LoadBalancer
    ingress:
      enabled: true
      hostname: kamaji.local
      ingressClassName: nginx
      additionalMetadata:
        annotations:
          kubernetes.io/ingress.allow-http: "false"
          nginx.ingress.kubernetes.io/secure-backends: "true"
          nginx.ingress.kubernetes.io/ssl-passthrough: "true"
  kubernetes:
    version: "v1.23.1"
    kubelet:
      cgroupfs: systemd
    admissionControllers:
      - ResourceQuota
      - LimitRanger
  networkProfile:
    address: "127.0.0.1"
    port: 6443
    certSANs:
      - "test.clastix.labs"
    serviceCidr: "10.96.0.0/16"
    podCidr: "10.244.0.0/16"
    dnsServiceIPs:
      - "10.96.0.10"
  addons:
    coreDNS: {}
    kubeProxy: {}

Enabling an Ingress requires the toggle value tcp.spec.ingress.enabled, and this leads to several issues, since the field hostname cannot be marked as mandatory, given the fact the IngressSpec doesn't allow a nil value.

As we implemented with addons, we should consider the Ingress toggable by defining struct values, rather than by toggle.

Example of enabled Ingress

apiVersion: kamaji.clastix.io/v1alpha1
kind: TenantControlPlane
metadata:
  name: test
spec:
  controlPlane:
    deployment:
      replicas: 1
    service:
      serviceType: NodePort
    ingress:
      hostname: test.kamaji.local
      ingressClassName: nginx
      additionalMetadata:
        annotations:
          kubernetes.io/ingress.allow-http: "false"
          nginx.ingress.kubernetes.io/secure-backends: "true"
          nginx.ingress.kubernetes.io/ssl-passthrough: "true"
  kubernetes:
    version: "v1.23.1"
    kubelet:
      cgroupfs: systemd
    admissionControllers:
      - ResourceQuota
      - LimitRanger
  networkProfile:
    address: "10.0.1.32"
    port: 31443
  addons:
    coreDNS: {}
    kubeProxy: {}

Example of disabled Ingress

apiVersion: kamaji.clastix.io/v1alpha1
kind: TenantControlPlane
metadata:
  name: test
spec:
  controlPlane:
    deployment:
      replicas: 1
    service:
      serviceType: NodePort
  kubernetes:
    version: "v1.23.1"
    kubelet:
      cgroupfs: systemd
    admissionControllers:
      - ResourceQuota
      - LimitRanger
  networkProfile:
    address: "10.0.1.32"
    port: 31443
  addons:
    coreDNS: {}
    kubeProxy: {}

[maxgio92]

The only required field to enable the Ingress would be the spec.ingress.hostname @prometherion?

[prometherion]

When you are using an Ingress, it would be.

Right now it's not from the API definition, but it's from the code since there's no way to set up this condition.

[bsctl]

@prometherion it seems good to me, can we turn this into a feature request?

[prometherion]

Closing this since implemented back in the days with 886113c.