Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read: "Manage" link can overlap (with large images) #87

Open
Chealer opened this issue Jun 8, 2020 · 0 comments
Open

read: "Manage" link can overlap (with large images) #87

Chealer opened this issue Jun 8, 2020 · 0 comments

Comments

@Chealer
Copy link

Chealer commented Jun 8, 2020

When browsing with administrative privileges, the read page displays a "Manage" ("Éditer" in French) link allowing admins to edit the application. This link is positioned pretty much at the top, which makes sense given its importance. It is also wisely positioned to the right, to preserve vertical space.

More precisely, the element is absolutely positioned, 36 pixels below its parent's top. This is surely to prevent overlap between Manage and long titles. But unfortunately, that only moves the problem down. It works with the first 1 or 2 lines of titles, but leaves several possibilities for overlap, with either:

  1. A title which fills at least 2 or 3 lines
  2. An image which takes the full width
  3. If there is no image, a description which takes more than 1 line

The following screenshot demonstrates case #2:
showcase Manage


We are experiencing this with showcase 1.2.0, but looking at the code, I am convinced that master (1.3.0) is also affected.

The proper way to avoid such overlap is to reserve the space taken by the element, which can be done with relative positioning and using CSS float: right instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant