Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flask-debugtoolbar does not scroll #6995

Open
florianm opened this issue Aug 3, 2022 · 7 comments · May be fixed by #8047
Open

flask-debugtoolbar does not scroll #6995

florianm opened this issue Aug 3, 2022 · 7 comments · May be fixed by #8047

Comments

@florianm
Copy link
Contributor

florianm commented Aug 3, 2022

CKAN version
2.10.0a0

Describe the bug
A clear and concise description of what the bug is.
The flask-debugtoolbar (FDT) does not scroll, as CKAN is affected by pallets-eco/flask-debugtoolbar#181.
A fix is in the making at pallets-eco/flask-debugtoolbar#182.

Steps to reproduce

  • Enable debug mode.
  • Expand the debug toolbar, select a tab with lots of content, e.g. templates.
  • The screen content shows an overflow, but does not scroll.

Expected behavior
The FDT should scroll where needed.

Additional details
A simplistic patch is here.

This bug can be fixed by bumping the FDT version once their PR has been merged.

@muhammed-ajmal
Copy link

I would like to work on this issue @wardi

@alexmorev
Copy link
Member

Have the same problem. Actually the issue is in fixed position of #flDebug .flDebugPanelContentParent selector. Change it to absolute in your browser inspector and it'll work. Or you should wait for someones merging.

@florianm
Copy link
Contributor Author

That upstream PR seems to be close to being merged. On the CKAN side, the fix could be as simple as bumping FDT version.

@Gauravp-NEC
Copy link
Contributor

That upstream PR seems to be close to being merged. On the CKAN side, the fix could be as simple as bumping FDT version.

@florianm , On CKAN side where we need to bumping FDT version?

@florianm
Copy link
Contributor Author

@Gauravp-NEC
I would review the contrib guides for process and do a code search to see whether a PR here would need anything more than just bumping the fdt version in the dev requirements.

@florianm
Copy link
Contributor Author

Upstream is merged, pending a new release of FDT.

@Surge-Ricky
Copy link

For anyone else looking for help with this, the fix above only makes it so that the right panel is scrollable.. For people like me with LONG pages of debugging information, the center did not scroll. Very easy fix for me at least. Find a browser extension that lets you overwrite CSS, or you can probably implement this css fix into your base layout template, and use this css:

#flDebug, #flDebug * {
overflow-y: auto;
}

@Labuschagne-Miro Labuschagne-Miro linked a pull request Feb 1, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants