Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group/Org Bulk Actions Skip Framework #7997

Open
JVickery-TBS opened this issue Dec 28, 2023 · 0 comments · May be fixed by #8037
Open

Group/Org Bulk Actions Skip Framework #7997

JVickery-TBS opened this issue Dec 28, 2023 · 0 comments · May be fixed by #8037
Assignees

Comments

@JVickery-TBS
Copy link
Contributor

CKAN version

2.9+ (including master branch)

Describe the bug

When using the group bulk actions to update datasets to private/public or to delete them, the bulk logic action methods do not call the package logic methods, they just hit the DB directly, and SOLR directly. So this would skip any before and after hooks.

Steps to reproduce

Steps to reproduce the behavior:

  • Have some code which implements IPackageController and the delete or after_dataset_delete methods;
  • Have some dataset for an organization;
  • Go to the organization's bulk action page;
  • Select some datasets and delete;
  • The delete and after_dataset_delete implemented methods do not happen.

Expected behavior

IPackageController method implementations happen for each dataset selected for the bulk actions.

@JVickery-TBS JVickery-TBS changed the title Group.Org Bulk Actions Skip Framework Group/Org Bulk Actions Skip Framework Dec 28, 2023
@TomeCirun TomeCirun linked a pull request Jan 29, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants