-
Notifications
You must be signed in to change notification settings - Fork 2k
/
test_create.py
535 lines (393 loc) · 17.9 KB
/
test_create.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
# encoding: utf-8
"""Unit tests for ckan/logic/auth/create.py.
"""
import unittest.mock as mock
import pytest
import ckan.model as model
import ckan.tests.factories as factories
import ckan.tests.helpers as helpers
logic = helpers.logic
def test_anon_cant_create():
context = {"user": None, "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("package_create", context)
@pytest.mark.ckan_config("ckan.auth.anon_create_dataset", True)
def test_anon_can_create():
context = {"user": None, "model": model}
assert helpers.call_auth("package_create", context)
@pytest.mark.ckan_config("ckan.auth.anon_create_dataset", True)
@pytest.mark.ckan_config(
"ckan.auth.create_dataset_if_not_in_organization", False
)
def test_cdnio_overrides_acd():
context = {"user": None, "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("package_create", context)
@pytest.mark.ckan_config("ckan.auth.anon_create_dataset", True)
@pytest.mark.ckan_config("ckan.auth.create_unowned_dataset", False)
def test_cud_overrides_acd():
context = {"user": None, "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("package_create", context)
@pytest.mark.usefixtures("non_clean_db")
class TestUserCreate:
def test_sysadmin_can_create_via_api(self):
sysadmin = factories.Sysadmin()
context = {"user": sysadmin["name"], "model": model, "api_version": 3}
assert helpers.call_auth("user_create", context)
def test_anon_can_not_create_via_web(self):
context = {"user": None, "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("user_create", context)
def test_anon_cannot_create_via_api(self):
context = {"user": None, "model": model, "api_version": 3}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("user_create", context)
@pytest.mark.ckan_config("ckan.auth.create_user_via_web", False)
def test_anon_cannot_create_via_forbidden_web(self):
context = {"user": None, "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("user_create", context)
@pytest.mark.ckan_config("ckan.auth.create_user_via_api", True)
def test_anon_not_create_via_allowed_api(self):
context = {"user": None, "model": model, "api_version": 3}
assert helpers.call_auth("user_create", context)
@pytest.mark.usefixtures("non_clean_db")
class TestRealUsersAuth(object):
def test_no_org_user_can_create(self):
user = factories.User()
context = {"user": user["name"], "model": model}
assert helpers.call_auth("package_create", context)
@pytest.mark.ckan_config("ckan.auth.anon_create_dataset", True)
@pytest.mark.ckan_config(
"ckan.auth.create_dataset_if_not_in_organization", False
)
def test_no_org_user_cant_create_if_cdnio_false(self):
user = factories.User()
context = {"user": user["name"], "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("package_create", context)
@pytest.mark.ckan_config("ckan.auth.anon_create_dataset", True)
@pytest.mark.ckan_config("ckan.auth.create_unowned_dataset", False)
def test_no_org_user_cant_create_if_cud_false(self):
user = factories.User()
context = {"user": user["name"], "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("package_create", context)
def test_same_org_user_can_create(self):
user = factories.User()
org_users = [{"name": user["name"], "capacity": "editor"}]
org = factories.Organization(users=org_users)
dataset = {"name": "same-org-user-can-create", "owner_org": org["id"]}
context = {"user": user["name"], "model": model}
assert helpers.call_auth("package_create", context, **dataset)
def test_different_org_user_cant_create(self):
user = factories.User()
org_users = [{"name": user["name"], "capacity": "editor"}]
factories.Organization(users=org_users)
org2 = factories.Organization()
dataset = {
"name": "different-org-user-cant-create",
"owner_org": org2["id"],
}
context = {"user": user["name"], "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("package_create", context, **dataset)
@mock.patch("ckan.logic.auth.create.group_member_create")
def test_user_invite_delegates_correctly_to_group_member_create(self, gmc):
user = factories.User()
context = {"user": user["name"], "model": None, "auth_user_obj": user}
data_dict = {"group_id": 42}
gmc.return_value = {"success": False}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("user_invite", context=context, **data_dict)
gmc.return_value = {"success": True}
assert helpers.call_auth("user_invite", context=context, **data_dict)
@pytest.mark.ckan_config("ckan.plugins", "image_view")
@pytest.mark.usefixtures("with_plugins")
def test_authorized_if_user_has_permissions_on_dataset(self):
user = factories.User()
dataset = factories.Dataset(user=user)
resource = factories.Resource(user=user, package_id=dataset["id"])
resource_view = {
"resource_id": resource["id"],
"title": u"Resource View",
"view_type": u"image_view",
"image_url": "url",
}
context = {"user": user["name"], "model": model}
response = helpers.call_auth(
"resource_view_create", context=context, **resource_view
)
assert response
@pytest.mark.ckan_config("ckan.plugins", "image_view")
@pytest.mark.usefixtures("with_plugins")
def test_not_authorized_if_user_has_no_permissions_on_dataset(self):
org = factories.Organization()
user = factories.User()
member = {"username": user["name"], "role": "admin", "id": org["id"]}
helpers.call_action("organization_member_create", **member)
user_2 = factories.User()
dataset = factories.Dataset(owner_org=org["id"])
resource = factories.Resource(package_id=dataset["id"])
resource_view = {
"resource_id": resource["id"],
"title": u"Resource View",
"view_type": u"image_view",
"image_url": "url",
}
context = {"user": user_2["name"], "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
"resource_view_create", context=context, **resource_view
)
@pytest.mark.ckan_config("ckan.plugins", "image_view")
@pytest.mark.usefixtures("with_plugins")
def test_not_authorized_if_not_logged_in_3(self):
resource_view = {
"title": u"Resource View",
"view_type": u"image_view",
"image_url": "url",
}
context = {"user": None, "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
"resource_view_create", context=context, **resource_view
)
def test_authorized_if_user_has_permissions_on_dataset_3(self):
user = factories.User()
dataset = factories.Dataset(user=user)
resource = factories.Resource(user=user, package_id=dataset["id"])
context = {"user": user["name"], "model": model}
response = helpers.call_auth(
"resource_create_default_resource_views",
context=context,
resource=resource,
)
assert response
def test_not_authorized_if_user_has_no_permissions_on_dataset_2(self):
org = factories.Organization()
user = factories.User()
member = {"username": user["name"], "role": "admin", "id": org["id"]}
helpers.call_action("organization_member_create", **member)
user_2 = factories.User()
dataset = factories.Dataset(owner_org=org["id"])
resource = factories.Resource(package_id=dataset["id"])
context = {"user": user_2["name"], "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
"resource_create_default_resource_views",
context=context,
resource=resource,
)
def test_not_authorized_if_not_logged_in_2(self):
dataset = factories.Dataset()
resource = factories.Resource(package_id=dataset["id"])
context = {"user": None, "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
"resource_create_default_resource_views",
context=context,
resource=resource,
)
def test_authorized_if_user_has_permissions_on_dataset_2(self):
user = factories.User()
dataset = factories.Dataset(user=user)
context = {"user": user["name"], "model": model}
response = helpers.call_auth(
"package_create_default_resource_views",
context=context,
package=dataset,
)
assert response
def test_not_authorized_if_user_has_no_permissions_on_dataset_3(self):
org = factories.Organization()
user = factories.User()
member = {"username": user["name"], "role": "admin", "id": org["id"]}
helpers.call_action("organization_member_create", **member)
user_2 = factories.User()
dataset = factories.Dataset(owner_org=org["id"])
context = {"user": user_2["name"], "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
"package_create_default_resource_views",
context=context,
package=dataset,
)
def test_not_authorized_if_not_logged_in(self):
dataset = factories.Dataset()
context = {"user": None, "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
"package_create_default_resource_views",
context=context,
package=dataset,
)
def test_authorized_if_user_has_permissions_on_dataset_4(self):
user = factories.User()
dataset = factories.Dataset(user=user)
resource = {
"package_id": dataset["id"],
"title": "Resource",
"url": "http://test",
"format": "csv",
}
context = {"user": user["name"], "model": model}
response = helpers.call_auth(
"resource_create", context=context, **resource
)
assert response
def test_not_authorized_if_user_has_no_permissions_on_dataset_4(self):
org = factories.Organization()
user = factories.User()
member = {"username": user["name"], "role": "admin", "id": org["id"]}
helpers.call_action("organization_member_create", **member)
user_2 = factories.User()
dataset = factories.Dataset(user=user, owner_org=org["id"])
resource = {
"package_id": dataset["id"],
"title": "Resource",
"url": "http://test",
"format": "csv",
}
context = {"user": user_2["name"], "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("resource_create", context=context, **resource)
def test_not_authorized_if_not_logged_in_4(self):
resource = {"title": "Resource", "url": "http://test", "format": "csv"}
context = {"user": None, "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("resource_create", context=context, **resource)
def test_sysadmin_is_authorized(self):
sysadmin = factories.Sysadmin()
resource = {"title": "Resource", "url": "http://test", "format": "csv"}
context = {"user": sysadmin["name"], "model": model}
response = helpers.call_auth(
"resource_create", context=context, **resource
)
assert response
def test_raises_not_found_if_no_package_id_provided(self):
user = factories.User()
resource = {"title": "Resource", "url": "http://test", "format": "csv"}
context = {"user": user["name"], "model": model}
with pytest.raises(logic.NotFound):
helpers.call_auth("resource_create", context=context, **resource)
def test_raises_not_found_if_dataset_was_not_found(self):
user = factories.User()
resource = {
"package_id": "does_not_exist",
"title": "Resource",
"url": "http://test",
"format": "csv",
}
context = {"user": user["name"], "model": model}
with pytest.raises(logic.NotFound):
helpers.call_auth("resource_create", context=context, **resource)
class TestApiToken(object):
def test_anon_is_not_allowed_to_create_tokens(self):
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
u"api_token_create", {u"user": None, u"model": model}
)
@pytest.mark.usefixtures(u"non_clean_db")
def test_auth_user_is_allowed_to_create_tokens(self):
user = factories.User()
helpers.call_auth(
u"api_token_create",
{u"model": model, u"user": user[u"name"]},
user=user[u"name"],
)
@pytest.fixture
def members_fixtures():
org_admin = factories.User()
org_editor = factories.User()
org_member = factories.User()
org = factories.Organization(
users=[
{'name': org_admin['name'], 'capacity': 'admin'},
{'name': org_editor['name'], 'capacity': 'editor'},
{'name': org_member['name'], 'capacity': 'member'},
]
)
dataset = factories.Dataset(owner_org=org['id'])
return locals()
@pytest.mark.usefixtures("non_clean_db")
@pytest.mark.ckan_config(u"ckan.auth.allow_dataset_collaborators", True)
class TestPackageMemberCreateAuth(object):
def _get_context(self, user):
return {
"model": model,
"user": user if isinstance(user, str) else user.get("name"),
}
def test_create_org_admin_is_authorized(self, members_fixtures):
context = self._get_context(members_fixtures["org_admin"])
assert helpers.call_auth(
'package_collaborator_create', context=context, id=members_fixtures["dataset"]['id'])
def test_create_org_editor_is_not_authorized(self, members_fixtures):
context = self._get_context(members_fixtures["org_editor"])
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_create',
context=context, id=members_fixtures["dataset"]['id'])
def test_create_org_member_is_not_authorized(self, members_fixtures):
context = self._get_context(members_fixtures["org_member"])
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_create',
context=context, id=members_fixtures["dataset"]['id'])
def test_create_non_org_user_is_not_authorized(self, members_fixtures):
user = factories.User()
context = self._get_context(user)
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_create',
context=context, id=members_fixtures["dataset"]['id'])
def test_create_org_admin_from_other_org_is_not_authorized(self, members_fixtures):
org_admin2 = factories.User()
factories.Organization(
users=[
{'name': org_admin2['name'], 'capacity': 'admin'},
]
)
context = self._get_context(org_admin2)
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_create',
context=context, id=members_fixtures["dataset"]['id'])
def test_create_missing_org_is_not_authorized(self, members_fixtures):
dataset = factories.Dataset(owner_org=None)
context = self._get_context(members_fixtures["org_admin"])
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_create',
context=context, id=dataset['id'])
@pytest.mark.ckan_config('ckan.auth.allow_admin_collaborators', True)
def test_create_collaborator_admin_is_authorized(self, members_fixtures):
user = factories.User()
helpers.call_action(
'package_collaborator_create',
id=members_fixtures["dataset"]['id'], user_id=user['id'], capacity='admin')
context = self._get_context(user)
assert helpers.call_auth(
'package_collaborator_create', context=context, id=members_fixtures["dataset"]['id'])
@pytest.mark.parametrize('role', ['editor', 'member'])
def test_create_collaborator_editor_and_member_are_not_authorized(self, role, members_fixtures):
user = factories.User()
helpers.call_action(
'package_collaborator_create',
id=members_fixtures["dataset"]['id'], user_id=user['id'], capacity=role)
context = self._get_context(user)
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_create',
context=context, id=members_fixtures["dataset"]['id'])
@pytest.mark.ckan_config('ckan.auth.create_dataset_if_not_in_organization', True)
@pytest.mark.ckan_config('ckan.auth.create_unowned_dataset', True)
def test_create_unowned_datasets(self):
user = factories.User()
dataset = factories.Dataset(user=user)
assert dataset['owner_org'] is None
assert dataset['creator_user_id'] == user['id']
context = self._get_context(user)
assert helpers.call_auth(
'package_collaborator_create', context=context, id=dataset['id'])