-
Notifications
You must be signed in to change notification settings - Fork 2k
/
test_delete.py
295 lines (223 loc) · 9.58 KB
/
test_delete.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
# encoding: utf-8
"""Unit tests for ckan/logic/auth/delete.py.
"""
import pytest
from six import string_types
import ckan.logic.auth.delete as auth_delete
import ckan.tests.factories as factories
import ckan.tests.helpers as helpers
from ckan import model
logic = helpers.logic
@pytest.mark.usefixtures("clean_db", "with_request_context")
class TestDeleteAuth:
def test_anon_cant_delete(self):
context = {"user": None, "model": model}
params = {}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("resource_delete", context=context, **params)
def test_no_org_user_cant_delete(self):
user = factories.User()
org = factories.Organization()
dataset = factories.Dataset(
owner_org=org["id"], resources=[{"url": "https://example.com/data.csv"}]
)
response = auth_delete.resource_delete(
{"user": user["name"], "model": model},
{"id": dataset["resources"][0]["id"]},
)
assert not response["success"]
def test_org_user_can_delete(self):
user = factories.User()
org_users = [{"name": user["name"], "capacity": "editor"}]
org = factories.Organization(users=org_users)
dataset = factories.Dataset(
owner_org=org["id"], resources=[{"url": "https://example.com/data.csv"}], user=user
)
response = auth_delete.resource_delete(
{"user": user["name"], "model": model, "auth_user_obj": user},
{"id": dataset["resources"][0]["id"]},
)
assert response["success"]
@pytest.mark.ckan_config("ckan.plugins", "image_view")
@pytest.mark.usefixtures("with_plugins")
def test_anon_cant_delete_2(self):
context = {"user": None, "model": model}
params = {}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
"resource_view_delete", context=context, **params
)
@pytest.mark.ckan_config("ckan.plugins", "image_view")
@pytest.mark.usefixtures("with_plugins")
def test_no_org_user_cant_delete_2(self):
user = factories.User()
org = factories.Organization()
dataset = factories.Dataset(
owner_org=org["id"], resources=[{"url": "https://example.com/data.csv"}]
)
resource_view = factories.ResourceView(
resource_id=dataset["resources"][0]["id"]
)
context = {"user": user["name"], "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
"resource_view_delete", context=context, id=resource_view["id"]
)
@pytest.mark.ckan_config("ckan.plugins", "image_view")
@pytest.mark.usefixtures("with_plugins")
def test_org_user_can_delete_2(self):
user = factories.User()
org_users = [{"name": user["name"], "capacity": "editor"}]
org = factories.Organization(users=org_users)
dataset = factories.Dataset(
owner_org=org["id"], resources=[{"url": "https://example.com/data.csv"}], user=user
)
resource_view = factories.ResourceView(
resource_id=dataset["resources"][0]["id"]
)
context = {"user": user["name"], "model": model}
response = helpers.call_auth(
"resource_view_delete", context=context, id=resource_view["id"]
)
assert response
def test_anon_cant_clear():
context = {"user": None, "model": model}
params = {}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("resource_view_clear", context=context, **params)
@pytest.mark.usefixtures("with_request_context")
def test_normal_user_cant_clear():
user = factories.User()
context = {"user": user["name"], "model": model}
with pytest.raises(logic.NotAuthorized):
helpers.call_auth("resource_view_clear", context=context)
@pytest.mark.usefixtures("with_request_context")
def test_sysadmin_user_can_clear():
user = factories.User(sysadmin=True)
context = {"user": user["name"], "model": model}
response = helpers.call_auth("resource_view_clear", context=context)
assert response
class TestApiToken(object):
def test_anon_is_not_allowed_to_revoke_tokens(self):
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
u"api_token_revoke",
{u"user": None, u"model": model}
)
@pytest.mark.usefixtures(u"clean_db")
def test_auth_user_is_allowed_to_revoke_tokens(self):
user = factories.User()
token = model.ApiToken(user[u"id"])
model.Session.add(token)
model.Session.commit()
helpers.call_auth(u"api_token_revoke", {
u"model": model,
u"user": user[u"name"]
}, jti=token.id)
@pytest.mark.usefixtures(u"clean_db")
def test_auth_user_is_allowed_to_revoke_unowned_tokens(self):
owner = factories.User()
not_owner = factories.User()
token = model.ApiToken(owner[u"id"])
model.Session.add(token)
model.Session.commit()
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(u"api_token_revoke", {
u"model": model,
u"user": not_owner[u"name"]
}, jti=token.id)
@pytest.mark.usefixtures(u"clean_db")
def test_auth_user_is_allowed_to_revoke_unexisting_tokens(self):
user = factories.User()
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(u"api_token_revoke", {
u"model": model,
u"user": user[u"name"]
}, jti='not-exists')
@pytest.mark.usefixtures("clean_db")
@pytest.mark.ckan_config(u"ckan.auth.allow_dataset_collaborators", True)
class TestPackageMemberDeleteAuth(object):
def _get_context(self, user):
return {
'model': model,
'user': user if isinstance(user, string_types) else user.get('name')
}
def setup(self):
self.org_admin = factories.User()
self.org_editor = factories.User()
self.org_member = factories.User()
self.normal_user = factories.User()
self.org = factories.Organization(
users=[
{'name': self.org_admin['name'], 'capacity': 'admin'},
{'name': self.org_editor['name'], 'capacity': 'editor'},
{'name': self.org_member['name'], 'capacity': 'member'},
]
)
self.dataset = factories.Dataset(owner_org=self.org['id'])
def test_delete_org_admin_is_authorized(self):
context = self._get_context(self.org_admin)
assert helpers.call_auth(
'package_collaborator_delete',
context=context, id=self.dataset['id'])
def test_delete_org_editor_is_not_authorized(self):
context = self._get_context(self.org_editor)
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_delete',
context=context, id=self.dataset['id'])
def test_delete_org_member_is_not_authorized(self):
context = self._get_context(self.org_member)
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_delete',
context=context, id=self.dataset['id'])
def test_delete_org_admin_from_other_org_is_not_authorized(self):
org_admin2 = factories.User()
factories.Organization(
users=[
{'name': org_admin2['name'], 'capacity': 'admin'},
]
)
context = self._get_context(org_admin2)
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_delete',
context=context, id=self.dataset['id'])
def test_delete_missing_org_is_not_authorized(self):
dataset = factories.Dataset(owner_org=None)
context = self._get_context(self.org_admin)
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_delete',
context=context, id=dataset['id'])
@pytest.mark.ckan_config('ckan.auth.allow_admin_collaborators', True)
def test_delete_collaborator_admin_is_authorized(self):
user = factories.User()
helpers.call_action(
'package_collaborator_create',
id=self.dataset['id'], user_id=user['id'], capacity='admin')
context = self._get_context(user)
assert helpers.call_auth(
'package_collaborator_delete', context=context, id=self.dataset['id'])
@pytest.mark.parametrize('role', ['editor', 'member'])
def test_delete_collaborator_editor_and_member_are_not_authorized(self, role):
user = factories.User()
helpers.call_action(
'package_collaborator_create',
id=self.dataset['id'], user_id=user['id'], capacity=role)
context = self._get_context(user)
with pytest.raises(logic.NotAuthorized):
helpers.call_auth(
'package_collaborator_delete',
context=context, id=self.dataset['id'])
@pytest.mark.ckan_config('ckan.auth.create_dataset_if_not_in_organization', True)
@pytest.mark.ckan_config('ckan.auth.create_unowned_dataset', True)
def test_delete_unowned_datasets(self):
user = factories.User()
dataset = factories.Dataset(user=user)
assert dataset['owner_org'] is None
assert dataset['creator_user_id'] == user['id']
context = self._get_context(user)
assert helpers.call_auth(
'package_collaborator_delete', context=context, id=dataset['id'])