Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive spacing in Wagtail header formatting #199

Open
popovayoana opened this issue Jan 4, 2024 · 9 comments
Open

Excessive spacing in Wagtail header formatting #199

popovayoana opened this issue Jan 4, 2024 · 9 comments
Assignees

Comments

@popovayoana
Copy link

popovayoana commented Jan 4, 2024

Description

There is an issue with the formatting of headers (H1, H2, H3 etc) in Wagtail. There appears to be inconsistent and excessive spacing in two key areas:

  1. Between Headers - the spacing between different headers (H1, H2, H3 etc) is larger than expected, disrupting the flow and readability of the content
  2. Between Text and Headers - there is excessive space between the end of a text block and the subsequent header, leading to a disjointed visual presentation

Expected Behavior

The spacing between headers and between text and headers should be uniform and adhere to standard web content formatting practices. This ensures a cohesive, visually appealing layout that enhances readability.

How it looks like now

image
image

@popovayoana
Copy link
Author

@alexmorev @Alex-Pavlyuk hey guys! first, happy new year! ; )) may your debug sessions be short, your coffee/tea strong, and your connections with others meaningful! second, can you look into that? : )) thanks!

@alexmorev alexmorev added the in progress the work is in progress label Jan 16, 2024
@Alex-Pavlyuk
Copy link
Member

@popovayoana we will start to work on it soon

@Alex-Pavlyuk
Copy link
Member

@popovayoana it is changed now pls check

@Alex-Pavlyuk Alex-Pavlyuk removed the in progress the work is in progress label Jan 16, 2024
@popovayoana
Copy link
Author

@Alex-Pavlyuk great job so far! just a couple of quick things to tweak:

  1. headings size: H3, H4, and H5 look almost the same size right now... H3's a bit different in color and padding, but could we make them more distinct in size?
  2. padding: let's match the padding with the heading sizes - it'll look neater that way...

size
image

padding
image

@Alex-Pavlyuk Alex-Pavlyuk added in progress the work is in progress and removed in testing labels Jan 31, 2024
@alexmorev
Copy link
Member

@popovayoana It's done. Please check. Waiting for your feedback.

@popovayoana
Copy link
Author

@alexmorev nothing has changed for me so far... 😕 should I wait a bit? I'm testing with this article: https://ckan.org/admin/pages/376/view_draft/

@alexmorev
Copy link
Member

@popovayoana Fixed. Please re-check.
image

@Alex-Pavlyuk Alex-Pavlyuk assigned popovayoana and unassigned alexmorev Feb 6, 2024
@Alex-Pavlyuk Alex-Pavlyuk removed the in progress the work is in progress label Feb 6, 2024
@popovayoana
Copy link
Author

popovayoana commented Feb 9, 2024

@alexmorev the header font size is perfect! we just need to tweak the line height for h2, h4 and h5. not super sure but I'm leaning towards maintaining a consistent 4px difference between font size and line height. why 4px? - it's already looking good on h1 and h3, unless I'm mistaken

here’s a tentative suggestion (but please, apply your expertise to adjust as you see fit - h4 and h5 should be slightly decreased and h2 very tiny-tiny increased):

  • for h2, now at Size 40px and Line Height 42px → Let's try Line Height to 44px
  • for h4, now at Size 28px and Line Height 42px → Let's try Line Height 32px
  • for h5, now at Size 24px and Line Height 36px → Let's try Line Height 28px

image

@alexmorev
Copy link
Member

alexmorev commented Feb 11, 2024

@popovayoana Changed. Please check and give your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants