Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pymbar and high/infinity energies #22

Open
halx opened this issue Dec 10, 2015 · 3 comments
Open

pymbar and high/infinity energies #22

halx opened this issue Dec 10, 2015 · 3 comments

Comments

@halx
Copy link

halx commented Dec 10, 2015

Hi,

I am using pymbar through David Mobley's alchemical-analysis tool. I
want to do BAR/MBAR analysis with AMBER. Strangely, AMBER will
occasionally output very high energies, sometimes not even displaying
the values anymore (Fortran all '*' output), for estimates for
'far-away" lambdas.

Anyway, I am wondering what pymbar does with high energies or 'Inf'
values. I have tried to filter those out and compare with passing those
values to pymbar. It seems that the results are the same. So, what
does really happen?

Many thanks,
Hannes.

@jchodera
Copy link
Member

Excellent question. I'm not sure inputs containing inf have been rigorously tested in pymbar 3.x, but in principle, there is no problem with the mathematics because we are always working with the quantity exp[-u], which is 0 when this occurs.

The safest thing to do right now is to replace occurrences of inf with some energy that is larger than the most negative energy by some reasonable amount---say, 1000 kT. That will ensure there are no numerical issues int he resulting computation.

In the meantime, I will make a note to add some unit tests with inf energies.

@jchodera
Copy link
Member

Whoops---this should not go in this issue tracker, but rather here:

https://github.com/choderalab/pymbar/issues

@halx
Copy link
Author

halx commented Dec 10, 2015

Sorry, for asking this on the wrong tracker.

I guess the exp[-u] sort this out just fine. I will modify the AMBER
parser to let these values pass through and probably also change 'Inf' to
something 'high'.

On 10 December 2015 at 15:01, John Chodera notifications@github.com wrote:

Excellent question. I'm not sure inputs containing inf have been
rigorously tested in pymbar 3.x, but in principle, there is no problem with
the mathematics because we are always working with the quantity exp[-u],
which is 0 when this occurs.

The safest thing to do right now is to replace occurrences of inf with
some energy that is larger than the most negative energy by some reasonable
amount---say, 1000 kT. That will ensure there are no numerical issues int
he resulting computation.

In the meantime, I will make a note to add some unit tests with inf
energies.


Reply to this email directly or view it on GitHub
#22 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants