Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of sampling test for harmonic oscillator #681

Open
ijpulidos opened this issue Apr 7, 2023 · 0 comments
Open

Improve robustness of sampling test for harmonic oscillator #681

ijpulidos opened this issue Apr 7, 2023 · 0 comments

Comments

@ijpulidos
Copy link
Contributor

From time to time we get stochastic test failures for the TestHarmonicOscillatorsMultiStateSampler with the following traceback:

Traceback (most recent call last):
  File "/home/runner/micromamba-root/envs/openmmtools-test/lib/python3.10/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/runner/work/openmmtools/openmmtools/openmmtools/tests/test_sampling.py", line 230, in test_with_unsampled_states
    self.run(include_unsampled_states=True)
  File "/home/runner/work/openmmtools/openmmtools/openmmtools/tests/test_sampling.py", line 223, in run
    raise Exception("Dimensionless free energy difference exceeds MAX_SIGMA of %.1f" % MAX_SIGMA)
Exception: Dimensionless free energy difference exceeds MAX_SIGMA of 6.0

Even if these are commonly worked around just by re-running the workflow we probably need a more robust way of testing this system.

@ijpulidos ijpulidos added this to the 0.22.1 milestone Apr 7, 2023
@ijpulidos ijpulidos removed this from the 0.22.1 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant