Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More pythonic way to pass args. #39

Open
hmacdope opened this issue Jan 19, 2024 · 1 comment
Open

More pythonic way to pass args. #39

hmacdope opened this issue Jan 19, 2024 · 1 comment
Assignees

Comments

@hmacdope
Copy link
Contributor

          Now that I think about it more pythonic would be to pass these as named args rather than a dict with an expected structure but we can discuss as is big API change.

Originally posted by @hmacdope in #38 (comment)

@kaminow kaminow self-assigned this Jan 19, 2024
@kaminow
Copy link
Collaborator

kaminow commented Jan 19, 2024

yeah this makes sense and shouldn't be too difficult. I had it this way initially because that's how some of the underlying models expect the input, but I can just as easily package as a dict on the fly as unpackage for the other models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants