Addressing overuse of fixtures #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@chrisiacovella , can you please look at the two tests still failing in the dataset test module? I can't figure out why these are not passing, I think it has to do with the caching. |
|
I think that one is ready for review! @chrisiacovella , could you please take a look at the failing tests for the dataset, I can't figure out what is going wrong here. |
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have accumulated technical debts in the configuration of some of our tests. This PR is a first attempt to clean up the overuse of slightly similar but different fixtures, for which the control flow is hidden in
conftest.py,making it sometimes difficult to understand what is done in a particular test.I opted for explicitly passing control parameters to each test instead of hiding these in fixtures. I have cleaned up some of the fixtures and simplified them where appropriate. We still use fixtures to set up datasets/databases/database containers. (Sidenote: In one of the next PRs, we need to address the inflationary use of the word dataset in the classes --- it is challenging to distinguish between some of the concepts without reading the documentation.)
Todos
Status