Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support openfe 1.0, gufe 1.0 #31

Open
dotsdl opened this issue Mar 5, 2024 · 2 comments
Open

Changes to support openfe 1.0, gufe 1.0 #31

dotsdl opened this issue Mar 5, 2024 · 2 comments
Milestone

Comments

@dotsdl
Copy link
Member

dotsdl commented Mar 5, 2024

There are changes in openfe and gufe for their respective 1.0 releases, in particular in Settings. These should be addressed in advance of a new feflow release.

@richardjgowers can give more insights into what has changed in these packages.

@dotsdl dotsdl added this to the 0.1.0 release milestone Mar 5, 2024
@IAlibay IAlibay mentioned this issue Mar 6, 2024
12 tasks
@IAlibay
Copy link
Collaborator

IAlibay commented Mar 6, 2024

From an initial look, this is going to require a reasonably large amount of changes in the NEQ protocol, at least the way mappings are handled needs changing.

I've taken an initial test stab in #33 - happy to hand over as necessary @ijpulidos

@ijpulidos
Copy link
Contributor

In order to keep things more modular and easier to understand I'm going to enumerate the things that will be needed for us to support 1.0 releases of gufe and openfe.

TODO:

  • Fix IntegratorSettings
    • Make a new integrator settings class for NEQ integrator
  • Fix solvation settings
    • should be just an import replacement
  • Deal with mapping changes
    • SIngle mapping validation
    • Make sure everything is now a list rather than a dictionary
    • Remove dependency on "ligand" dictionary entry in mapping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants