Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolkit wrapper should not issue IncorrectNumConformersWarning #20

Open
Tracked by #38
jchodera opened this issue Mar 2, 2023 · 3 comments
Open
Tracked by #38

Toolkit wrapper should not issue IncorrectNumConformersWarning #20

jchodera opened this issue Mar 2, 2023 · 3 comments

Comments

@jchodera
Copy link
Member

jchodera commented Mar 2, 2023

From #19:

By the way, also the warning Espaloma gives (for which I'm deleting here the conformer) seems a bit excessive. It feels to me like it could just silently ignore the existence of conformers in the molecule.

IncorrectNumConformersWarning: Molecule 'Molecule with name 'BEN_pH7_4.sdf' and SMILES '[H][c]1[c]([H])[c]([H])[c]([C]([N]([H])[H])=[N+]([H])[H])[c]([H])[c]1[H]'' has 1 conformers, but charge method 'espaloma-am1bcc' expects exactly 0
@mikemhenry
Copy link
Contributor

This warning should be easy enough to ignore with a context manager filtering warnings, do we think that there is any case where this warning could be useful?

@jchodera
Copy link
Member Author

jchodera commented Mar 4, 2023

Nope!

Instead of suppressing the warning, should there be a way to tell ToolkitWrapper there is no need to check this?

@j-wags
Copy link
Collaborator

j-wags commented Mar 9, 2023

Ah, this is happening because mol_copy in the wrapper isn't bring updated with the user-defined confs (which defaults to None). You can fix this by putting mol_copy._conformers = use_conformers here.

@mikemhenry mikemhenry mentioned this issue Apr 25, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants