Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrain EspalomaCharge with resonance-invariant features #18

Open
Tracked by #38
jchodera opened this issue Mar 1, 2023 · 0 comments
Open
Tracked by #38

Retrain EspalomaCharge with resonance-invariant features #18

jchodera opened this issue Mar 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jchodera
Copy link
Member

jchodera commented Mar 1, 2023

Thanks to @ljmartin in #16, we realize we used a resonance-sensitive feature atom.GetTotalValence() in the training of EspalomaCharge 0.0.8.

I've opened this issue so we can track progress toward the following updates:

  • Retraining EspalomaCharge using the resonance-invariant atom.GetDegree() instead
  • Removing the ability for users to specify net charge in charge()
  • Adding tests to make sure the total partial charge matches the net formal charge (to within a tolerance)
  • Adding tests to make sure carboxylates and other resonance-equivalent atoms end up with the same partial charge
  • Releasing a new version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant