Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make plotmol take in categories #902

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

JenkeScheen
Copy link
Contributor

@JenkeScheen JenkeScheen commented Mar 6, 2024

This PR enables plotting in asap-alchemy predict using categories. This is useful because now we can split a scatterplot (bokeh) by e.g. MoleculeSet. Some quick things to resolve (@jthorton let's discuss):

One caveat to this approach is that uncertainty whiskers don't disappear when a category is hidden (using the legend). Can fix that in a later iteration!

Status

  • Ready to go

Developers certificate of origin

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Merging #902 (e33fdee) into main (cf611d1) will decrease coverage by 0.04%.
The diff coverage is 40.00%.

Additional details and impacted files

@hmacdope
Copy link
Collaborator

@jthorton would you mind giving this a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants