Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asap-docking don't return None in POSITDocker #997

Closed
wants to merge 2 commits into from
Closed

asap-docking don't return None in POSITDocker #997

wants to merge 2 commits into from

Conversation

apayne97
Copy link
Contributor

@apayne97 apayne97 commented Apr 18, 2024 •
edited

Description

fixes #989

Todos

Notable points that this PR has either accomplished or will accomplish.

  • change POSITDocker to not return anything in the case of a skipped failure
  • write a test to catch this bug

Questions

  • in terms of test writing - it seems overkill to go through docking that we know fails just to test what happens when it fails, but I'm not sure how else to test it?

Status

  • Ready to go

Developers certificate of origin

@apayne97 apayne97 changed the title Fix docking bug asap-docking don't return None in POSITDocker Apr 18, 2024
@apayne97 apayne97 requested a review from hmacdope April 18, 2024 21:12
@apayne97 apayne97 added the small label Apr 18, 2024
@hmacdope
Copy link
Collaborator

See my comment on the issue?

@apayne97 apayne97 mentioned this pull request Apr 23, 2024
Closed
4 tasks
@hmacdope hmacdope mentioned this pull request Apr 26, 2024
Merged
1 task
@hmacdope
Copy link
Collaborator

Incorporated in #1018

@hmacdope
Copy link
Collaborator

Fixed in #1018

@hmacdope hmacdope closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmacdope hmacdope Awaiting requested review from hmacdope

Assignees
No one assigned
Labels
small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asap-docking Missing docking result causes a bug
2 participants
@apayne97 @hmacdope