Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow viewing package creation validation rules via new choco rule command #3381

Closed
2 tasks done
AdmiringWorm opened this issue Jan 15, 2024 · 1 comment · Fixed by #3382
Closed
2 tasks done

Allow viewing package creation validation rules via new choco rule command #3381

AdmiringWorm opened this issue Jan 15, 2024 · 1 comment · Fixed by #3382
Assignees
@AdmiringWorm
Labels
5 - Released Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Milestone
2.3.0

Comments

@AdmiringWorm
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

No response

Describe The Solution. Why is it needed?

In Version 2.0.0 we implemented a service that can collect and run rules that are validated when a package is created.

As of right now, there is no visibility of what these rules are doing, and what they currently implement. As such, we should implement a command that can be used to list out any rules that are available, and to view the details of such a rule as well.

Additional Context

While this may be too helpful currently, there are plans in the future to implement something that will make such a rule command more useful (outside Chocolatey CLI).

To have this ability already implemented at that time makes it so that a user does not need to update Chocolatey CLI when these features are available.

Related Issues

No response
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 15, 2024
@AdmiringWorm
(chocolatey#3381) Add new rule command
53325d0 
This adds a new command called ´rule` with an alias of `rules` to be
able to view any Validation Rules that have been implemented by
Chocolatey CLI, or the details of a specific view.

This allows a user to see what is implemented when they are packaging
their Chocolatey CLI package. This is intended to be used in the future
to enhance other functionality.
@AdmiringWorm AdmiringWorm mentioned this issue Jan 15, 2024
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 15, 2024
@AdmiringWorm
(chocolatey#3381) Add new rule command
7c32f0e 
This adds a new command called ´rule` with an alias of `rules` to be
able to view any Validation Rules that have been implemented by
Chocolatey CLI, or the details of a specific view.

This allows a user to see what is implemented when they are packaging
their Chocolatey CLI package. This is intended to be used in the future
to enhance other functionality.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 15, 2024
@AdmiringWorm
(chocolatey#3381) Add new rule command
3570985 
This adds a new command called ´rule` with an alias of `rules` to be
able to view any Validation Rules that have been implemented by
Chocolatey CLI, or the details of a specific view.

This allows a user to see what is implemented when they are packaging
their Chocolatey CLI package. This is intended to be used in the future
to enhance other functionality.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 15, 2024
@AdmiringWorm
(chocolatey#3381) Add new rule command
a8bb1e9 
This adds a new command called ´rule` with an alias of `rules` to be
able to view any Validation Rules that have been implemented by
Chocolatey CLI, or the details of a specific view.

This allows a user to see what is implemented when they are packaging
their Chocolatey CLI package. This is intended to be used in the future
to enhance other functionality.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 26, 2024
@AdmiringWorm
(chocolatey#3381) Add new rule command
7d34e1e 
This adds a new command called ´rule` with an alias of `rules` to be
able to view any Validation Rules that have been implemented by
Chocolatey CLI, or the details of a specific view.

This allows a user to see what is implemented when they are packaging
their Chocolatey CLI package. This is intended to be used in the future
to enhance other functionality.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 26, 2024
@AdmiringWorm
(chocolatey#3381) Add new rule command
6a8d488 
This adds a new command called ´rule` with an alias of `rules` to be
able to view any Validation Rules that have been implemented by
Chocolatey CLI, or the details of a specific view.

This allows a user to see what is implemented when they are packaging
their Chocolatey CLI package. This is intended to be used in the future
to enhance other functionality.
@AdmiringWorm AdmiringWorm self-assigned this Jan 26, 2024
@gep13 gep13 added this to the 2.3.0 milestone May 7, 2024
@gep13 gep13 added Feature Issues that introduce new functionality to the project, instead of updating existing functionality and removed FeatureParity labels May 7, 2024
gep13 pushed a commit to AdmiringWorm/choco that referenced this issue May 20, 2024
@AdmiringWorm @gep13
(chocolatey#3381) Add new rule command
2f78dba 
This adds a new command called ´rule` with an alias of `rules` to be
able to view any Validation Rules that have been implemented by
Chocolatey CLI, or the details of a specific view.

This allows a user to see what is implemented when they are packaging
their Chocolatey CLI package. This is intended to be used in the future
to enhance other functionality.
gep13 pushed a commit to AdmiringWorm/choco that referenced this issue May 21, 2024
@AdmiringWorm @gep13
(chocolatey#3381) Add new rule command
0c777c7 
This adds a new command called ´rule` with an alias of `rules` to be
able to view any Validation Rules that have been implemented by
Chocolatey CLI, or the details of a specific view.

This allows a user to see what is implemented when they are packaging
their Chocolatey CLI package. This is intended to be used in the future
to enhance other functionality.
gep13 added a commit that referenced this issue May 21, 2024
@gep13
Merge pull request #3382 from AdmiringWorm/rule-command
3727152 
(#3381) Add new rule command
@gep13 gep13 added 4 - Done and removed 3 - Review labels May 21, 2024
gep13 added a commit that referenced this issue May 22, 2024
@gep13
(#3381) Add tab completion for rule command
a6e6f2b 
With the addition of the new choco rule command, we need to update the
tab completion to allow usage of the command.  This includes both the
new command name itself, as well as the options that are available to
the rule.
gep13 added a commit that referenced this issue May 22, 2024
@gep13
(#3381) Add Pester tests for rule tab expansion
681e4e6 
This commit adds some Pester tests to ensure that the output for the
rule command, during tab expansion, works as expected.
gep13 added a commit to gep13/choco that referenced this issue May 24, 2024
@gep13
(chocolatey#3381) Add Pester tests for rule command
a00264f 
The next release includes a new choco rule command, that allows
displaying information about the validation rules that are currently in
use by Chocolatey CLI.

This commit adds basic Pester tests for exercising this command, along
with its subcommands.
corbob pushed a commit to gep13/choco that referenced this issue May 27, 2024
@gep13 @corbob
(chocolatey#3381) Add Pester tests for rule command
699ebfc 
The next release includes a new choco rule command, that allows
displaying information about the validation rules that are currently in
use by Chocolatey CLI.

This commit adds basic Pester tests for exercising this command, along
with its subcommands.
gep13 added a commit to gep13/choco that referenced this issue May 28, 2024
@gep13
(chocolatey#3381) Add Pester tests for rule command
073d4c7 
The next release includes a new choco rule command, that allows
displaying information about the validation rules that are currently in
use by Chocolatey CLI.

This commit adds basic Pester tests for exercising this command, along
with its subcommands.
@pauby pauby changed the title Add command to allow viewing any rules implemented by Chocolatey CLI or an extension Allow viewing package creation validation rules May 28, 2024
vexx32 pushed a commit to gep13/choco that referenced this issue May 30, 2024
@gep13 @vexx32
(chocolatey#3381) Add Pester tests for rule command
160bcb1 
The next release includes a new choco rule command, that allows
displaying information about the validation rules that are currently in
use by Chocolatey CLI.

This commit adds basic Pester tests for exercising this command, along
with its subcommands.
gep13 added a commit to gep13/choco that referenced this issue May 30, 2024
@gep13
(chocolatey#3381) Add Pester tests for rule command
a46f1df 
The next release includes a new choco rule command, that allows
displaying information about the validation rules that are currently in
use by Chocolatey CLI.

This commit adds basic Pester tests for exercising this command, along
with its subcommands.
gep13 added a commit that referenced this issue Jun 5, 2024
@gep13
Merge branch 'release/2.3.0'
5dc8330 
* release/2.3.0: (153 commits)
  (#23) Move call to SetRemotePackageNamesIfAllSpecified
  (#1901) Revert commit to display location
  (maint) Update Authenticode Signature
  (tests) Some minor tweaks for test consistency
  (#310) Set-EnvironmentVariable: delete values properly
  (tests) Remove v2 import tests
  (#310) Fix test issues
  (#310) Fixup v2 compatibility
  (tests) Working on tests during pairing session
  (#2050) Add Pester test for --ignore-pinned option
  (#3381) Add Pester tests for rule command
  (#1144) Add Pester test to cover hash validation
  (#72) Add Pester tests to cover new functionality
  (test) Update assertions for push commands
  (#1310) Add Pester test to validate output
  (#23) Add tests to handle install all
  (#2200) Add test for new enhanced exit code
  (#1764) Add test for new enhanced exit code
  (#1760) Add test for new enhanced exit code
  (#1759) Add test for new enhanced exit code
  ...
@gep13 gep13 changed the title Allow viewing package creation validation rules Allow viewing package creation validation rules via new choco rule command Jun 5, 2024
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

gep13 added a commit that referenced this issue Jun 5, 2024
@gep13
Merge branch 'master' into develop
484999b 
* master: (37 commits)
  (#310) Fix path to chocolatey.lib files
  (maint) Corrected casing of file
  (#23) Move call to SetRemotePackageNamesIfAllSpecified
  (#1901) Revert commit to display location
  (maint) Update Authenticode Signature
  (tests) Some minor tweaks for test consistency
  (#310) Set-EnvironmentVariable: delete values properly
  (tests) Remove v2 import tests
  (#310) Fix test issues
  (#310) Fixup v2 compatibility
  (tests) Working on tests during pairing session
  (#2050) Add Pester test for --ignore-pinned option
  (#3381) Add Pester tests for rule command
  (#1144) Add Pester test to cover hash validation
  (#72) Add Pester tests to cover new functionality
  (test) Update assertions for push commands
  (#1310) Add Pester test to validate output
  (#23) Add tests to handle install all
  (#2200) Add test for new enhanced exit code
  (#1764) Add test for new enhanced exit code
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
5 - Released Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

(#3381) Add new rule command AdmiringWorm/choco
3 participants
@gep13 @AdmiringWorm @choco-bot