Add more gamepad binds to Heretic and Hexen #1666 - Dpad not being recognized

[Crazy-bat11]

Background

Version of Chocolate Doom: latest git version

Operating System and version: Linux Mint 21.2 Cinnamon

Game: Doom/Heretic/Hexen/Strife
Joystick: Thrustmaster Dual Analog 4

Bug description

Observed behavior: I cannot bind the Dpad to any movement or action. This behavior is observed in the setups of Doom. Heretic, Hexen and Strife.

[mikeday0]

Quick question: Do you know what version of SDL2 you have?

[mikeday0]

Also were you starting with an old configuration? If so, please open the setup utility > Configure Gamepad/Joystick, press enter on Controller, then press a button on the controller. This will refresh the configuration to use the updated game controller interface.

[Crazy-bat11]

Hi, firstly I would like to thank you for implementing this new code.
My SDL2 version is 2.0.20. But, you are right. I was using an old configuration, After refreshing, the new config appeared and the Dpad is recognized (I can bind it to any action). Thank you for your help.

Do you intend to implement a "more controls' option in Strife setup too? And speaking of Strife, when you are talking to a npc, the fire button is also used to select a dialogue line. This makes you involuntarily attack the npc.

[ceski-1]

And speaking of Strife, when you are talking to a npc, the fire button is also used to select a dialogue line. This makes you involuntarily attack the npc.

This is vanilla behavior unfortunately. The original game has an awful hack to work around this for mouse input (mouse_fire_countdown) but nothing for gamepad input. Even with the mouse hack, it's still possible to accidentally attack NPCs if the button is pressed fast enough.

Here's the relevant section of code:

chocolate-doom/src/strife/g_game.c

Lines 542 to 553 in f254d21

	// villsa [STRIFE]: Moved mousebuttons[mousebfire] to below
	if (gamekeydown[key_fire] || joybuttons[joybfire])
	cmd->buttons |= BT_ATTACK;
	// villsa [STRIFE]
	if(mousebuttons[mousebfire])
	{
	if(mouse_fire_countdown <= 0)
	cmd->buttons |= BT_ATTACK;
	else
	--mouse_fire_countdown;
	}

And here's a discussion of the mouse hack when I was dealing with it for Crispy Strife: fabiangreffrath#1014

I'm not sure how that can be fixed while also preserving the Chocolate philosophy. And if the mouse hack is copied over, then it makes gamepad attacks have the same delay bug outside of NPC dialogue. Maybe others here can suggest something.

[mikeday0]

Hi, firstly I would like to thank you for implementing this new code. My SDL2 version is 2.0.20. But, you are right. I was using an old configuration, After refreshing, the new config appeared and the Dpad is recognized (I can bind it to any action). Thank you for your help.

Do you intend to implement a "more controls' option in Strife setup too? And speaking of Strife, when you are talking to a npc, the fire button is also used to select a dialogue line. This makes you involuntarily attack the npc.

No problem! Glad to hear the issue was resolved.

As for Strife, I do plan to expand the gamepad/joystick binds. I am somewhat lacking the confidence to do so at the moment as I am not as familiar with the game compared to Doom, Heretic and Hexen.

[fabiangreffrath]

So, can this get closed?