fix(config_parser): handle substitutions with resolved values of type ConfigValues #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M0dEx
commented
Jan 18, 2024
Comment on lines
-664
to
+665
| if not isinstance(resolved_value, ConfigValues): | ||
|
|
||
| if resolved_value: |
There was a problem hiding this comment.
Is there a reason for this specific check?
There was a problem hiding this comment.
After I've removed this check, the parsing succeeds in some cases, where it previously failed, but fails in some cases, where it succeeded previously.
|
Thanks for your contribution @M0dEx! Released new version 0.3.61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #321, where substitutions are not correctly resolved when nested in subsections and having dependents from another config file.