Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO]: Add unit tests for recently added *Transform classes #823

Open
hwpang opened this issue Apr 22, 2024 · 0 comments
Open

[TODO]: Add unit tests for recently added *Transform classes #823

hwpang opened this issue Apr 22, 2024 · 0 comments
Labels
todo add an item to the to-do list
Milestone

Comments

@hwpang
Copy link
Contributor

hwpang commented Apr 22, 2024

Notes
See here for details. Copied the comment below:

LGTM. Perhaps we should use the *Transform classes in the integration tests to catch this type of error. That can be a separate PR.

good point! We should have:

  • unit tests for our transforms: ensure the math/implementation is correct
  • integration tests for our new models: ensure that training and evaluation output domains are different, i.e., our training outputs should have μ^≃0,σ^≃1 and our evaluation outputs should have μ^≃μ,σ^≃σ (roughly equal to our training statistics)
@hwpang hwpang added the todo add an item to the to-do list label Apr 22, 2024
@kevingreenman kevingreenman added this to the v2.1.0 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo add an item to the to-do list
Projects
None yet
Development

No branches or pull requests

2 participants