{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":108289,"defaultBranch":"main","name":"ohai","ownerLogin":"chef","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2009-01-15T20:50:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/29740?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716929710.0","currentOid":""},"activityList":{"items":[{"before":"6337ab5f7d3f098dc24dfa823294cffafff7f241","after":"89c59d182678e327b90bb6bebc6803f30f73d8dc","ref":"refs/heads/main","pushedAt":"2024-05-28T20:55:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chef-expeditor[bot]","name":null,"path":"/apps/chef-expeditor","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/28108?s=80&v=4"},"commit":{"message":"Bump version to 18.1.18 by Chef Expeditor\n\nObvious fix; these changes are the result of automation not creative thinking.","shortMessageHtmlLink":"Bump version to 18.1.18 by Chef Expeditor"}},{"before":"6d64237f9987c3bf51805e19884e6e710c3a40f6","after":"6337ab5f7d3f098dc24dfa823294cffafff7f241","ref":"refs/heads/main","pushedAt":"2024-05-28T20:54:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"tpowell-progress","name":"Thomas Powell","path":"/tpowell-progress","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/104777878?s=80&v=4"},"commit":{"message":"[lspci] Fix handling of more than one PCIe root port (#1822)\n\nSummary:\r\nI'm guessing most machines only have one PCIe root port, but things like ARM hosts tend to have more, and that breaks as it creates collisions.\r\n\r\nAs we want to keep backwards compatibility, and `lspci` is run with the defaults that doesn't show the root port if it's `0000`, only add it when it's non-zero, and also add it as a new extra field called `root_port` to denote the fact that there is one (useful when using the BDF to find files on disk, as when there is no `root_port`, one needs to add the extra `0000:`.\r\n\r\nMore detailed explanation I wrote on the slack channel:\r\nOn Linux, we run `lspci -vnnmk`, which will show the BDF in the first `Device:` field. So the first bug is that the regular expression on https://github.com/chef/ohai/blob/main/lib/ohai/plugins/linux/lspci.rb#L54 is missing a `\\` before the `.`, therefore will will match `0001:02:03.4` as `01:02:03` which is plain broken. But fixing that we end up with `02:03.4` which is also plain wrong as it loses the root complex.\r\nI see a few ways we could fix this:\r\n\r\n1. Highly disruptive: we add -D to lspci, which means we'll always get the root complex even when it's 0000 . This is terrible 'cause it will basically break everything\r\n2. We do this but only with an option in ohai. Less terrible, but means people have to know about that option\r\n3. We do this but only when we notice more than one root complex. That's not really doable\r\n4. We add a new field, root_complex in the PCI structure, which is 0000 by default and the actual root complex for everything else\r\n\r\nI like 4 the most, as it mirrors closely what lspci does (https://github.com/pciutils/pciutils/blob/master/lspci.c#L285)\r\nor maybe 5. We do it the same way lspci does it: if the root complex is 0, we just store the BDF as the ID, if it's not, we store the root complex + BDF\r\nwe can't really do 4 'cause we might have collisions... Like if you have 0000:01:02.3 and 0001:01:02.3 then they have to be stored differently. So we can either do:\r\nOption A: 01:02.3 and 0001:01:02.3 (this can co-exist with everything today)\r\nOption B: 00000:1:02.3 and 0001:01:02.3 (this most likely needs to become pci2)\r\n\r\nTest Plan:\r\nBefore:\r\n```\r\n$ ohai | jq .pci\\|keys\r\n[\r\n \"00:00.0\",\r\n \"01:00.0\",\r\n \"01:00.1\",\r\n \"02:00:0\",\r\n \"04:00:0\",\r\n \"08:00:0\",\r\n \"08:01:0\",\r\n \"08:02:0\",\r\n \"08:03:0\",\r\n \"08:04:0\",\r\n \"08:05:0\",\r\n \"09:00:0\",\r\n \"09:01:0\"\r\n]\r\n```\r\n\r\nAfter:\r\n```\r\n$ ohai | jq .pci\\|keys\r\n[\r\n \"0002:00:00.0\",\r\n \"0004:00:00.0\",\r\n \"0008:00:00.0\",\r\n \"0008:01:00.0\",\r\n \"0008:02:01.0\",\r\n \"0008:02:02.0\",\r\n \"0008:03:00.0\",\r\n \"0008:04:00.0\",\r\n \"0008:05:00.0\",\r\n \"0009:00:00.0\",\r\n \"0009:01:00.0\",\r\n \"00:00.0\",\r\n \"01:00.0\",\r\n \"01:00.1\"\r\n]\r\n```\r\n\r\nReviewers: jaymzh\r\n\r\nCloses: #1693\r\n\r\nSigned-off-by: Olivier Raginel ","shortMessageHtmlLink":"[lspci] Fix handling of more than one PCIe root port (#1822)"}},{"before":"46d9507e0da7cbcbedc37937c6261d18d7abaa12","after":"2da4d09b3b92a99e664ef3130154237d69886b48","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T22:05:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"7fdcef6796334e412d1c31e0761e56d03c2c4be6","after":"46d9507e0da7cbcbedc37937c6261d18d7abaa12","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T21:55:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"686c7909364c8693678002579d7503ba5a54511f","after":"7fdcef6796334e412d1c31e0761e56d03c2c4be6","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T21:15:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"926bed944c0571e8b6a11ba21a5db79593e33b9d","after":"686c7909364c8693678002579d7503ba5a54511f","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T21:10:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"27be4b33f62fa1a8adae87e212d480580ea65312","after":"926bed944c0571e8b6a11ba21a5db79593e33b9d","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T20:57:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"a766a246f40d140d272b811879040bbf6a640fcc","after":"27be4b33f62fa1a8adae87e212d480580ea65312","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T20:55:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"fa4bf119347175cc9d8c722caa6b56994674f88c","after":"a766a246f40d140d272b811879040bbf6a640fcc","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T20:30:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"54b8478c7c3d6e62a61b4db294082664754c8154","after":"fa4bf119347175cc9d8c722caa6b56994674f88c","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T20:27:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"de72b9c5e864a00b03bd93cb8ba2a8ba374a418d","after":"54b8478c7c3d6e62a61b4db294082664754c8154","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T20:23:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"c8b05a8be3ca09fedf4b4913bd95a709b4fb84d2","after":"de72b9c5e864a00b03bd93cb8ba2a8ba374a418d","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T20:22:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"3782ab7ec6836019669fba08f714dbd2bfccdbad","after":"c8b05a8be3ca09fedf4b4913bd95a709b4fb84d2","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T20:18:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"52a24805042c8cc5f025a88433f92003c959c84a","after":"3782ab7ec6836019669fba08f714dbd2bfccdbad","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T20:15:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"d29e60f7f72216f502d149e7c01023cde5cbc39b","after":"52a24805042c8cc5f025a88433f92003c959c84a","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T20:11:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"e645736864c28d1632fa4d90f8b5d3cefe8706e9","after":"d29e60f7f72216f502d149e7c01023cde5cbc39b","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T19:59:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"a9b9f4e9872b1d963c6a5c4eff92cbfa92b43151","after":"e645736864c28d1632fa4d90f8b5d3cefe8706e9","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T19:57:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"7569b9d93e916eb40ab9f43d5b36fe1d42b45831","after":"a9b9f4e9872b1d963c6a5c4eff92cbfa92b43151","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T19:27:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now, adding puts statements\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now, adding puts statements"}},{"before":"b1f0102263b33523b7721b0340e3099ea573cf98","after":"7569b9d93e916eb40ab9f43d5b36fe1d42b45831","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T19:20:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now"}},{"before":"a60f5ad5c6f3d1655c5900b9b28652ef0a9e66df","after":"b1f0102263b33523b7721b0340e3099ea573cf98","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T14:37:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Debugging now\n\nSigned-off-by: John ","shortMessageHtmlLink":"Debugging now"}},{"before":"2d4bf72fd2a0cd6a1b6334b043014aef03f4d320","after":"a60f5ad5c6f3d1655c5900b9b28652ef0a9e66df","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T13:38:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Removing an errant 'end' from the monkey-patch\n\nSigned-off-by: John ","shortMessageHtmlLink":"Removing an errant 'end' from the monkey-patch"}},{"before":"948bf6af93bc42e4288cab6be2f7ad5725b3b32e","after":"2d4bf72fd2a0cd6a1b6334b043014aef03f4d320","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T13:33:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Monkey Patching Ohai to overcome issues with the Resolv class\n\nSigned-off-by: John ","shortMessageHtmlLink":"Monkey Patching Ohai to overcome issues with the Resolv class"}},{"before":"1ba6b3520b10ff17bd4f89d93a70c170f1e5cb5b","after":"929a523184482fbbf6bf753fbc6ce8ffbe1aed54","ref":"refs/heads/17-stable","pushedAt":"2024-03-21T13:33:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chef-expeditor[bot]","name":null,"path":"/apps/chef-expeditor","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/28108?s=80&v=4"},"commit":{"message":"Bump version to 17.9.7 by Chef Expeditor\n\nObvious fix; these changes are the result of automation not creative thinking.","shortMessageHtmlLink":"Bump version to 17.9.7 by Chef Expeditor"}},{"before":"e4ccd35ed48b5d0d6a4a02b8c15ae07d4439d694","after":null,"ref":"refs/heads/jfm/chef17-removing-ruby27-testing","pushedAt":"2024-03-21T13:32:51.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"}},{"before":"9bf7c7a1ed765f3b4a18c6b0a646ae9dfc269497","after":"1ba6b3520b10ff17bd4f89d93a70c170f1e5cb5b","ref":"refs/heads/17-stable","pushedAt":"2024-03-21T13:32:50.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Merge pull request #1821 from chef/jfm/chef17-removing-ruby27-testing\n\nRemoving Ruby 2.7 testing","shortMessageHtmlLink":"Merge pull request #1821 from chef/jfm/chef17-removing-ruby27-testing"}},{"before":null,"after":"e4ccd35ed48b5d0d6a4a02b8c15ae07d4439d694","ref":"refs/heads/jfm/chef17-removing-ruby27-testing","pushedAt":"2024-03-21T13:27:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Removing Ruby 2.7 testing\n\nSigned-off-by: John ","shortMessageHtmlLink":"Removing Ruby 2.7 testing"}},{"before":null,"after":"948bf6af93bc42e4288cab6be2f7ad5725b3b32e","ref":"refs/heads/jfm/chef17-monkey-patching-win32","pushedAt":"2024-03-21T13:16:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Monkey Patching Ohai to overcome issues with the Resolv class\n\nSigned-off-by: John ","shortMessageHtmlLink":"Monkey Patching Ohai to overcome issues with the Resolv class"}},{"before":null,"after":"e0db6392a4b3ea43bc002f85f01da0eaaf81a02f","ref":"refs/heads/jfm/chef17-testing-resolv","pushedAt":"2024-03-20T15:29:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Commenting out Resolv class\n\nSigned-off-by: John ","shortMessageHtmlLink":"Commenting out Resolv class"}},{"before":"73ebba274a88300ac2fa98831c3b483766080ade","after":"13bebd9b8e8321b9f9afe231134bbc3e65f29fb9","ref":"refs/heads/jfm/chef17-revert-ffi-2","pushedAt":"2024-03-19T19:37:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Reverting FFI\n\nSigned-off-by: John ","shortMessageHtmlLink":"Reverting FFI"}},{"before":null,"after":"73ebba274a88300ac2fa98831c3b483766080ade","ref":"refs/heads/jfm/chef17-revert-ffi-2","pushedAt":"2024-03-19T19:29:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"johnmccrae","name":"John McCrae","path":"/johnmccrae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4855887?s=80&v=4"},"commit":{"message":"Reverting FFI\n\nSigned-off-by: John ","shortMessageHtmlLink":"Reverting FFI"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEVkdfbAA","startCursor":null,"endCursor":null}},"title":"Activity ยท chef/ohai"}