-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: make the field 'collections' compatible between records and documents #3630
Conversation
The notion of "collection" was used many years ago for links such as:
Currently, and since many years, these are being redirected to the faceted search: (Note that the redirections are not perfect, e.g. the above 1st and 4th link That is to say that the "collection" notion is mostly of historical interest, Therefore, if we have in the docs values such as: "collections": [
{
"experiment": "CMS"
}
], This pull request transforms this to: "collections": [
"CMS"
], This is OK, but it should not be fully necessary, because the document will be I would therefore propose to go as far as to remove this field altogether in IOW, we should not really need to preserve the And for more complex field values, such as: "collections": [
{
"experiment": "CMS"
},
{
"primary": "education"
},
{
"year": "2010-2012"
}
], The education/research dichotomy was dropped e couple of years arly after the
These are now simply being redirected to show some convenient content. (Again The "year" collection is also outdated by the faceted search, where the Anyway, the long story short, the most important usage of the collection
(We should strive to return something good for links In documents, the collection field values are more varying, such as:
See that they mostly don't match the record values, and they are mostly Therefore, since the most important collection redirection (We already don't use the collection field in several docs pages such as P.S. Regardless of whether we go for my suggestion, we should still look into |
Thanks for the comments. I like the idea to simplify things, so I will use this PR to drop the collections from the |
a493a0f
to
bbc6f9d
Compare
No description provided.