Streamline API call flow (#142) #143
Conversation
cenpy/product.py
Outdated
|
|
||
| @lazy_property | ||
| def _legislative_year(self): | ||
| return 'NotImpementedError' |
There was a problem hiding this comment.
Should these be raise NotImplementedError() rather than return the string?
There was a problem hiding this comment.
Not in this case. _legislative_year is technically called on every layer lookup, but only formats if {legislative_year} is present in the string. If it raises an Exception, every query will fail.
layername_s = self._layer_lookup[for_geography].format(
census_year=self._census_year,
legislative_year=self._legislative_year,
congressional_district=self._congressional_district,
)Not sure if this was the best method, but it was the quickest. An alternative would to search for the placeholder and replace if present. Then we can easily raise exceptions.
|
I think this pull request might be ready for an initial review and potentially a There are still a handful of items that need to be bolted on in the near future:
Working Geographies
Whole GeographiesAlmost all whole geographies are currently working. There are also three specific whole geographies cases that didn't work:
These three are similar to
|
Closes #142