Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same-site BFCache #4059

Open
amaitland opened this issue Apr 6, 2022 · 2 comments
Open

Same-site BFCache #4059

amaitland opened this issue Apr 6, 2022 · 2 comments
Assignees

Comments

@amaitland
Copy link
Member

Creating this issue to investigate changes introduced by https://bitbucket.org/chromiumembedded/cef/commits/54dd34e19b56a2b7f0d6cb8d473ce36288dcf8e2

BFCache navigations do not trigger the same Chromium notifications as a normal
load. To avoid breaking CEF API usage expectations we now synthetically
generate the load-related callbacks that would otherwise be missing
(OnLoadingStateChange with isLoading=true, OnLoadStart, OnLoadEnd). The
|httpStatusCode| argument to OnLoadEnd will be 0 in this case.

LoadUrlAsync needs to be reviewed in light of these changes.

if (statusCode == 0)

@amaitland amaitland self-assigned this Apr 6, 2022
@amaitland amaitland added this to the 101.0.x milestone Apr 6, 2022
@amaitland
Copy link
Member Author

First need to confirm that Same-Site BFCache is enabled for the Alloy Runtime (I think it's still disabled by default)

@amaitland
Copy link
Member Author

For the Alloy runtime BFCache is permanently disabled https://github.com/chromiumembedded/cef/blob/4951/libcef/browser/alloy/alloy_browser_host_impl.cc#L1480

As the Chrome runtime will support hosting via a native window handle starting in M102 there's the potential this will still need checking.

Leaving open, removing milestone.

@amaitland amaitland removed this from the 101.0.x milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant