Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature or issue? #1064

Open
egonw opened this issue Apr 20, 2024 · 5 comments
Open

feature or issue? #1064

egonw opened this issue Apr 20, 2024 · 5 comments
Assignees

Comments

@egonw
Copy link
Member

egonw commented Apr 20, 2024

@johnmay, I really do not know if this is a bug or a feature, but I just notice this. Given the following two SMILES, depiction in CDK Depict doesn't work for the second:

[C@@H]1(OC([C@H](O)[C@H]([C@@H]1O)O)O*)CO
[C@@H]1(O[C@H]([C@H](O)[C@H]([C@@H]1O)O)O*)CO

image

I am attempting to define the stereo of the last stereocenter, just as a visual check, so that I can attach it as R group to various T2 toxins, see https://social.edu.nl/@egonw/112302962828702865

@johnmay
Copy link
Member

johnmay commented Apr 20, 2024

I presume it works if you don’t annotate the CIP labels.

CIP rules do not say anything about undefined atoms. The code tries to label as much as it can leave centres which may be R or S as unlabelled.

Note this does not mean they are undefined but a global label has no meaning. I’ll take a look as it should not throw and exception

@egonw
Copy link
Member Author

egonw commented Apr 24, 2024

CIP rules do not say anything about undefined atoms. The code tries to label as much as it can leave centres which may be R or S as unlabelled.

Ah, I did not mean about the CIP (something we did indeed discuss before), but should it throw an exception?

@johnmay
Copy link
Member

johnmay commented Apr 24, 2024

It's the CIP throwing the exception.

@johnmay
Copy link
Member

johnmay commented Apr 24, 2024

I need to find time to look at it, probably a simple fix.

@egonw
Copy link
Member Author

egonw commented Apr 24, 2024

I need to find time to look at it

not urgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants