Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_raw cannot handle ambiguous file formats #160

Open
cbrnr opened this issue Sep 1, 2020 · 2 comments
Open

read_raw cannot handle ambiguous file formats #160

cbrnr opened this issue Sep 1, 2020 · 2 comments
Labels

Comments

@cbrnr
Copy link
Owner

cbrnr commented Sep 1, 2020

The current implementation of read_raw (soon to be part of MNE) cannot distinguish between file formats that can contain either raw (continuous) or epoched data. For example, .FIF files can store both data types, but currently MNELAB assumes that .FIF files always contain continuous raw data. This should be changed in order to support loading epoched data.

@abcsds
Copy link
Contributor

abcsds commented Oct 6, 2020

Is this an upstream issue with mne.io.read_raw? I can check.

@cbrnr cbrnr added the bug label Dec 23, 2020
@cbrnr
Copy link
Owner Author

cbrnr commented Dec 9, 2022

This is not an upstream issue, and maybe the title of this issue is not accurate. It is OK that read_raw reads only raw (= continuous) files. Epochs are imported with read_epochs (only for FIFF files) and read_epochs_* for other file types (this is not consistent because read_epochs should be named read_epochs_fif maybe).

So it's really something that we need to check. If a user opens a FIFF file, we need to determine if it contains raw or epoched data and then call the appropriate function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants