-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Spring Zeebe SDK docs #3750
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
Thanks @christinaausley I will let you know when the PR is ready 👍 |
- Added explanation of missing client configuration properties - Removed reference to configuration with .properties file in favor of yaml files
As we did not migrate test package from the community spring SDK project, I am also removing this section from the docs: https://camunda.slack.com/archives/C06MPP9DQ21/p1715156875533999 Please see this thread.
66cdfdc
to
da8295b
Compare
stream-enabled: true | ||
``` | ||
|
||
This also works for every worker individual: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean this also works for every job worker individually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is my understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃 Should we fix the typo then?
This also works for every worker individual: | |
This also works for every worker individually: |
@@ -149,7 +149,7 @@ Camunda 8 doesn't provide integration into Jakarta EE application servers like C | |||
|
|||
### CDI or OSGI | |||
|
|||
Due to limited adoption, there is no support for CDI or OSGI in Camunda 8. A lightweight integration layer comparable to [Spring Zeebe](https://github.com/camunda-community-hub/spring-zeebe) might evolve in the feature, and we are happy to support this as a community extension to the Zeebe project. | |||
Due to limited adoption, there is no support for CDI or OSGI in Camunda 8. A lightweight integration layer comparable to the [Spring Zeebe SDK](../../apis-tools/spring-zeebe-sdk/getting-started.md) might evolve in the feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean a lightweight integration layer comparable to the Spring Zeebe SDK may be provided in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some small suggestion, but the changes look good otherwise 👍
@@ -76,37 +76,63 @@ If you are using IntelliJ: | |||
Settings > Build, Execution, Deployment > Compiler > Java Compiler | |||
``` | |||
|
|||
## Configuring the Zeebe cluster connection | |||
## Configuring Camunda 8 connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃 Just a suggestion
## Configuring Camunda 8 connection | |
## Configuring the Camunda 8 connection |
stream-enabled: true | ||
``` | ||
|
||
This also works for every worker individual: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃 Should we fix the typo then?
This also works for every worker individual: | |
This also works for every worker individually: |
Description
closes: #3748
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).