Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(spring-zeebe-sdk): add missing spring sdk properties #3757

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs(spring-zeebe-sdk): add missing spring sdk properties #3757

wants to merge 2 commits into from
+74 −16

Conversation

nicpuppa
Copy link
Contributor

@nicpuppa nicpuppa commented May 2, 2024 •
edited by ana-vinogradova-camunda

Description

Added missing Spring SDK properties
Added configuration for SaaS and SM cluster connections

closes: #3709

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@nicpuppa nicpuppa added kind/bug Issues related with bugs in the documentation component:zeebe Issues related with Zeebe project labels May 2, 2024
@nicpuppa nicpuppa self-assigned this May 2, 2024
@nicpuppa nicpuppa marked this pull request as ready for review May 2, 2024 13:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024 •
edited

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.5/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.5/apis-tools/spring-zeebe-sdk/configuration.md
  • versioned_docs/version-8.5/apis-tools/spring-zeebe-sdk/getting-started.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@nicpuppa nicpuppa marked this pull request as draft May 7, 2024 13:18
@christinaausley
Copy link
Contributor

@nicpuppa Is this still in draft because you have additional changes incoming, or is this ready for a final review?

@nicpuppa
Copy link
Contributor Author

@nicpuppa Is this still in draft because you have additional changes incoming, or is this ready for a final review?

Yes, we are adding more changes to the properties. I will ping you once is ready to be reviewed. Thanks @christinaausley 👍

@ana-vinogradova-camunda ana-vinogradova-camunda marked this pull request as ready for review May 30, 2024 09:59
nicpuppa and others added 2 commits May 30, 2024 15:43
@nicpuppa @ana-vinogradova-camunda
docs(spring-zeebe-sdk): add missing spring sdk properties
9f234da
@ana-vinogradova-camunda
fix: updating configuration.md with the correct setup
aa197e1 
Adding connection properties options for SaaS and SM
Removing duplicate properties from getting-started.md
@ana-vinogradova-camunda
Copy link
Contributor

@christinaausley this is now ready for the review 🙂

ana-vinogradova-camunda
ana-vinogradova-camunda approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@ana-vinogradova-camunda ana-vinogradova-camunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

koevskinikola
koevskinikola approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@koevskinikola koevskinikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koevskinikola koevskinikola koevskinikola approved these changes

@ana-vinogradova-camunda ana-vinogradova-camunda ana-vinogradova-camunda approved these changes

@megglos megglos Awaiting requested review from megglos

@christinaausley christinaausley Awaiting requested review from christinaausley

Assignees

@nicpuppa nicpuppa

@ana-vinogradova-camunda ana-vinogradova-camunda

Labels
component:zeebe Issues related with Zeebe project kind/bug Issues related with bugs in the documentation
Projects
Developer Experience
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Spring SDK] Some zeebe client properties are missing
4 participants
@nicpuppa @christinaausley @ana-vinogradova-camunda @koevskinikola