corrects naming for an error #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes #307
|
|
|
It seems like making PR was a mistake , no response since 8 days |
|
Hi, This is a valid PR. Could you please reopen this? |
Pull Request Test Coverage Report for Build 3385325265
💛 - Coveralls |
|
Hey @Harsh-br0, thank you for opening this pr! While this is of course a valid improvement, it is a breaking change. So I'm closing this for now until work starts on pyzeebe 4.0. |
|
Makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR...
Changes
UnkownGrpcStatusCodeErrorto UnknownGrpcStatusCodeErrorAPI Updates
Deprecations
This may affect old codebases having UnkownGrpcStatusCodeError naming convention.
Enhancements
Better understanding to guess the error precisely, instead to spell it incorrectly in code.
Also the unit tests are updated with changes
Checklist
References
This potentially fixes #307