Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show wait states before external service tasks #39

Closed
ingorichtsmeier opened this issue Jul 26, 2018 · 6 comments
Closed

show wait states before external service tasks #39

ingorichtsmeier opened this issue Jul 26, 2018 · 6 comments
Labels
Type: enhancement Enchancement of new feature of the software

Comments

@ingorichtsmeier
Copy link
Contributor

Create a red line to show a wait state infornt of an external service task.

@ingorichtsmeier ingorichtsmeier added the Type: enhancement Enchancement of new feature of the software label Jul 26, 2018
@StephenOTT
Copy link

StephenOTT commented Jul 27, 2018

@ingorichtsmeier I was working on a style for this related to #32. My thought was that it should be a slightly different wait state visual, than Async config as you can still apply a wait state (similar how you can apply a Async to a User Task).

Here is a example or how i was showing the difference between User Task implied aync, and the specific Async config:

41118430-ecb2bb7a-6a5d-11e8-9516-68b297dbb048

Thoughts on similar approach for external service task?
(Red is the manual async config, and the aqua is the implied)

@StephenOTT
Copy link

StephenOTT commented Jul 27, 2018

@ingorichtsmeier here is a example i just threw together from a unit test

screen shot 2018-07-27 at 11 36 12 am

Where the purple are the wait states for External tasks.
Red are Async Configs
Green is wait state for User Tasks

@ingorichtsmeier
Copy link
Contributor Author

Hi Steven, thank you for your worthful input. I just entered the issue during a training and had no time think about other improvements.

I think that the terms "Async before" - "Transaction boundary" - "Wait state" can be interchanged to your personal favor. In the end they all means the same: the process state is flushed to the database. In my opinion it complicates the understanding for beginners, if you try to find the differences between the three terms and put these into a generated image.

@ingorichtsmeier
Copy link
Contributor Author

External tasks should be mentioned here: /bpmn.js-report-template.html, line 128

@StephenOTT
Copy link

@ingorichtsmeier note that with a implicit wait state (user task, external task) vs a explicit wait (async before/after configs on a Task), a implicit does not require further config of job executor in a Unit test. But explicit requires extra job executions: Such as a User Task that is also configured as Async Before.

@rohwerj
Copy link
Collaborator

rohwerj commented May 18, 2024

Currently I don't see the need for this anymore. The user should in my opinion know, that some bpmn elements come with an inherent "wait state". So only asyncBefore and asyncAfter are import to be visualized, as they are otherwise not known to the user.

@rohwerj rohwerj closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement Enchancement of new feature of the software
Projects
None yet
Development

No branches or pull requests

3 participants