Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show overall coverage in HTML report if multiple suites are present in report #280

Open
rohwerj opened this issue Nov 30, 2022 · 3 comments
Labels
Type: enhancement Enchancement of new feature of the software

Comments

@rohwerj
Copy link
Collaborator

rohwerj commented Nov 30, 2022

If multiple suites are present in the report, the frontend shows the coverage for each suite but not an overall coverage (see attached screenshot).

CamundNoOverallCoverge

@rohwerj rohwerj added the Type: enhancement Enchancement of new feature of the software label Nov 30, 2022
@rohwerj
Copy link
Collaborator Author

rohwerj commented Nov 30, 2022

@alex-praschek do you think this can easily be integrated in the frontend?

@alex-praschek
Copy link
Contributor

Would it be enough to just count the distinct covered nodes and flows from each suite and compare it to the total node count of all models? I think that should be possible.

We will get wrong results though if multiple models share the same IDs, e.g. both models have a "ProcessStartEvent". But that happens also with multiple models in the same suite.

@rohwerj
Copy link
Collaborator Author

rohwerj commented Dec 12, 2022

@alex-praschek For the start I think this would be sufficient. Probably would be better in the future to always include the model key, when calculating the coverage. But we're also not doing that right now, when calculating the coverage for the assertion in junit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement Enchancement of new feature of the software
Projects
None yet
Development

No branches or pull requests

2 participants