Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure licence check plugin is working #217

Closed
zambrovski opened this issue Jun 22, 2022 · 8 comments · Fixed by #553
Closed

Make sure licence check plugin is working #217

zambrovski opened this issue Jun 22, 2022 · 8 comments · Fixed by #553
Assignees
Labels
Type: bug Confirmed bug in the software
Milestone

Comments

@zambrovski
Copy link
Collaborator

Either configure the licence check with licence set, or disable the plugin completely.
Currently just disabled it from the GH workflow.

@zambrovski zambrovski added the Type: bug Confirmed bug in the software label Jun 22, 2022
@DennisRieg
Copy link

Hello,
I also have the problem that our tests with coverage no longer run when the Camunda license is stored.
Greetings
Dennis

@zambrovski
Copy link
Collaborator Author

Could you have a look on that, @rohwerj ?

@DennisRieg
Copy link

JUnit-BPM-Coverage.zip

Hello Jan,
here is an example project.
The tests are green. If you put a camunda-licence.txt in the classpath (e.g. src/main/resources), there is an error when initializing the test coverage lib.
Thank you and greetings
Dennis

@rohwerj
Copy link
Collaborator

rohwerj commented Feb 15, 2023

Hello @DennisRieg.
This is very strange. I ran your project locally first without and then with a camunda license on the classpath.
For me it works in both cases.
I'm also sure that it picked up the license as the following line was in the output:
21:06:49.716 [main] INFO o.c.b.s.b.s.c.i.c.EnterLicenseKeyConfiguration - Found provided license file: camunda-license.txt
Is there something else in your setup?
Could you share the stacktrace or the output when the library fails to load?

@DennisRieg
Copy link

Hi @rohwerj,

I've attached the full output of maven clean install. The test fails for me with Java 11, 17 and 19 on a Mac M1.

Greetings
Dennis

output.txt

@rohwerj
Copy link
Collaborator

rohwerj commented Feb 16, 2023

Hi @DennisRieg.
This is really very strange. The error is an indicator, that the test execution listener is not correctly called at the setup of the tests.
I still cannot reproduce this problem locally. Tried with different Java versions and also tried to align the maven plugin versions with those from you log.
Still the tests succeed whether I have a valid camunda license in the classpath or not.
I'm currently out of ideas, but will continue to try to reproduce the error locally.
Is your license only a Camunda BPM license? Or a combined license for Optimize or Cawemo also?
Could you share the first line of the license key.
In my case it's --------------- BEGIN CAMUNDA BPM LICENSE KEY --------------- so nothing secret in there.

@DennisRieg
Copy link

Hi,
our licence starts with
--------------- BEGIN CAMUNDA BPM LICENSE KEY ---------------
hm, that is very strange.
I will try to run the example on a windows machine....
Greetings
Dennis

@DennisRieg
Copy link

Hm,

I can't reproduce it with the same example on a windows machine... Maybe this error has nothing todo with this great lib, but with camunda on Mac M1...

Greetings
Dennis

@rohwerj rohwerj added this to the 2.6.0 milestone May 22, 2024
rohwerj added a commit that referenced this issue May 22, 2024
rohwerj added a commit that referenced this issue May 22, 2024
…cense_check_and_add_headers

Bug/#217 enable license check and add headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Confirmed bug in the software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants