Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm_is_reftype_supers_of_extern seems unused #3400

Closed
yamt opened this issue May 7, 2024 · 2 comments
Closed

wasm_is_reftype_supers_of_extern seems unused #3400

yamt opened this issue May 7, 2024 · 2 comments

Comments

@yamt
Copy link
Collaborator

yamt commented May 7, 2024 

/Users/yamamoto/git/wasm-micro-runtime/core/iwasm/common/gc/gc_type.c:850:1: warning: unused function 'wasm_is_reftype_supers_of_extern' [-Wunused-function]
wasm_is_reftype_supers_of_extern(uint8 type)

i'm not familiar with the nearby logic to say if a removal is a correct fix.
@wenyongh
Copy link
Contributor

wenyongh commented May 7, 2024

Yes, it is unused after some code refactorings and can be removed now.

@TianlongLiang TianlongLiang mentioned this issue May 31, 2024
Merged
wenyongh pushed a commit that referenced this issue May 31, 2024
@TianlongLiang
Modify logging for windows exception handler and remove unused functi…
ab4e17b 
…on (#3489)

ps.
#3416
#3400
@wenyongh
Copy link
Contributor

wenyongh commented Jun 3, 2024

Close this issue since the unused function was removed in #3489.

@wenyongh wenyongh closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yamt @wenyongh