Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to prevent rule dropping? #89

Open
marcfielding1 opened this issue Jul 5, 2017 · 3 comments
Open

Is there a way to prevent rule dropping? #89

marcfielding1 opened this issue Jul 5, 2017 · 3 comments
Labels

Comments

@marcfielding1
Copy link

Heya,

So we've testing this out, it's really handy but it drops some rules the Eslint would support , for example ShellJS environment.

What are the criteria for rules being dropped, is it simply that they don't have a mapping presently?

Cheers

Marc

@brenolf
Copy link
Owner

brenolf commented Jul 5, 2017

Yes, exactly. So the way it works is by looking at some pre-defined dictionaries in lib/dictionaries. If it fails to find a file converting the rule you're targeting, then it drops that rule.

I tried my best to comply with all rules present in ESLint docs for v1.7.2, but maybe something changed in the between. Is this env coming from JSCS ou JSHint? Because it should be copying over if it comes from JSHint. If it's not, we have a bug.

@marcfielding1
Copy link
Author

marcfielding1 commented Sep 14, 2017

Hey Brenolf sorry I've just noticed this, let me pull the latest version and I'll check it to make sure I'm right, I can always whip up a PR if I've found some!

@brenolf
Copy link
Owner

brenolf commented Sep 14, 2017

Nothing has really changed since you opened the issue, other than supporting allButNested in eequireSpacesInsideObjectBrackets.

You're more than welcome to open a PR with a fix for anything you find that might be enhanced 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants