Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] improve testing set-up #285

Closed
alessandrofelder opened this issue Nov 29, 2023 · 2 comments · Fixed by #348
Closed

[Feature] improve testing set-up #285

alessandrofelder opened this issue Nov 29, 2023 · 2 comments · Fixed by #348
Labels
enhancement New feature or request

Comments

@alessandrofelder
Copy link
Member

Is your feature request related to a problem? Please describe.
By default, not all tests are run, neither in a local development environment nor on CI. You need to specify --runlocal --runslow to pytest.

Describe the solution you'd like
Either all tests are run always, or all tests are run by default locally (but not on CI)

Additional context

@adamltyson
Copy link
Member

FYI we do have a convention here: https://brainglobe.info/community/developers/testing.html#long-running-tests

@adamltyson
Copy link
Member

Just bumping this. Basically all the "slow" tests fail, but they're rarely run, so they may as well not be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants