Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability: Regular Expression Denial of Service in trim #491

Open
1 task done
trullarn opened this issue Feb 22, 2024 · 3 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@trullarn
Copy link

trullarn commented Feb 22, 2024

Have you read the Contributing Guidelines on issues?

Description

We have an audit right now and we need to resolve the issue of Event Catalog using an old version of "trim" through one of its dependencys

"Regular Expression Denial of Service in trim"

trim <0.0.3
Severity: high
Regular Expression Denial of Service in trim - GHSA-w5p7-h5w8-2hfq
fix available via npm audit fix
node_modules/trim
remark-parse <=8.0.3
Depends on vulnerable versions of trim
node_modules/@mdx-js/mdx/node_modules/remark-parse
node_modules/remark-mdx/node_modules/remark-parse
@mdx-js/mdx <=1.6.22
Depends on vulnerable versions of remark-mdx
Depends on vulnerable versions of remark-parse
node_modules/@mdx-js/mdx
next-mdx-remote <=3.0.8
Depends on vulnerable versions of @mdx-js/mdx
node_modules/next-mdx-remote
remark-mdx <=1.6.22
Depends on vulnerable versions of remark-parse
node_modules/remark-mdx

"npm autit fix" didnt fix it

It would seem that @mdx-js/react and next-mdx-remote needs to be updated to use a newer version of trim

Steps to reproduce

run "npm audit" to see the issue

Expected behavior

No vulnerabilities :)

Actual behavior

The repo uses an old version of the "trim" package which exposes it to vulnerabilities.

Your environment

  • EventCatalog version used: 1.2.5
  • Environment name and version (e.g. Chrome 89, Node.js 16.4): Node 20
  • Operating system and version (e.g. Ubuntu 20.04.2 LTS): MacOS
@trullarn trullarn added the bug Something isn't working label Feb 22, 2024
@trullarn
Copy link
Author

Any ETA on this?
There are probably more companies that needs this to be resolved when they do security audits =)

Thanks for a great product!

@jnixon2
Copy link

jnixon2 commented Mar 8, 2024

Any update on these vulnerabilities being patched at all?

@boyney123
Copy link
Owner

Thanks for the issue. Will try and get to this, unless you can try to update the packages and let us know how you get on. Happy to accept a PR too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants