Duplicate nodes in NodeGraph and Visualizer

[kbret1]

Have you read the Contributing Guidelines on issues?

• I have read the Contributing Guidelines on issues.

Description

The Domain NodeGraph and Visualizer shows duplicate nodes.

Steps to reproduce

git clone https://github.com/kbret1/EventCatalogTest.git
cd EventCatalogTest
yarn
yarn build
yarn start

Expected behavior

Domain NodeGraph and Visualizer should not have duplicate nodes.

Actual behavior

Duplicate nodes are included.

Your environment

• EventCatalog Core version used: 1.1.0
• Environment name and version: Version 117.0.5938.149 (Official Build) (arm64)
• Operating system and version: MacBook 14.0 (23A344)

[jr-araujo]

I'm also facing this issue! I lost some hours trying to figure out where could be the spot of the duplication and I saw that it could be a BUG on the NodeGraph component of the eventcatalog platform.

@boyney123 any news about it?

[steve-curran]

I am also facing this issue while evaluating this tool for adaption by our company - @boyney123

[flashmatt]

We've hit the same issue.

It would appear the Domain graph is split into publishers and subscribers and in your case @kbret1 because your service does not subscribe to anything it looks like the graph is duplicating. We noticed this on our Master Data service which publishes but does not consume.

Looking at the demo: https://app.eventcatalog.dev/domains/Orders/ It seems this is the desired behaviour but I would argue that it is better to show this in one graph instead of separate. @boyney123 would you accept a pull request to inline these into one graph? Something along the lines of:

[ PaymentProcessed ] -> Subscribed by -> [ Orders Service ]-> Publishes -> [ Order Complete ]-> subscribed by ->[ Data Lake ]

We haven't done any work to see if this is possible, I just want to confirm before we look at it.

@robert-sykes FYI

[s1mrankaur]

My service is subscribing and it is still duplicated. @kbret1 @boyney123

[boyney123]

app.eventcatalog.dev/domains/Orders

Hey @flashmatt

Ah yeah I see the issue, yeah feel free to make a pull request and look into this, happy to accept that if you still have the time and bandwidth, makes sense to me!

[s1mrankaur]

Any fixes in sight for this issue?

[boyney123]

I'm currently rewriting parts in V2 of EventCatalog, faster file system reads etc. Part of this I have moved to dagre for rendering nodes, I believe this may fix the issue! So hopefully I can get something deployed soon for you all to test.