New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move sampledata files to pip/conda installable package #13856
Comments
I have most of a @bokeh/dev would it be sufficient to just generate a PyPI package for this? Or do we need to also generate a conda package? |
Thanks for pushing forward with this so quickly. I'm currently a little swamped but hope to take a closer look early next week. A conda package would certainly be nice. |
@bokeh/dev the new repository is here https://github.com/bokeh/bokeh_sampledata Still need to set up CI, etc. If there is any more modern way to streamline package building and publishing I am all ears. |
As for how to integrate this here with a minimal of disruption, I have a vague idea of creating shim files in this repo that use module I was also considering date-based versioning for the new package as well. |
This should work. Another thing is you will need |
@hoxbro I am not sure I follow your comment, please have a look at the actual PR and let me know if there are some specific changes you think are needed. |
Moving the sampledata to an installable package will afford the following:
bokeh_sampledata
can depend onpandas
potentially allowing the main package to droppandas
pyodide
usage (however, it will be a large package... likely tens of MB)I think the simplest thing to do will be to keep all the existing
bokeh.sampledata.foo
modules as shims, and the ones that need to can try to access their data from the separatebokeh_sampledata
module. Ifbokeh_sampledata
cannot be imported then an actionable error can be raised. This approach will avoid any changes to examples and docs, which would otherwise be significant if we want to ripbokeh.sampledata
out of the main package entirely.If any of the "small" datasets currently shipped with the package depend on
pandas
they will need to be moved. Or maybe we just move all the actual data, but keep thebokeh.sampledata
shim module structure intact.cc @philippjfr
The text was updated successfully, but these errors were encountered: