Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Control over the Toolbar icons collapse #12486

Open
ofir-frd opened this issue Oct 13, 2022 · 11 comments
Open

[FEATURE] Control over the Toolbar icons collapse #12486

ofir-frd opened this issue Oct 13, 2022 · 11 comments

Comments

@ofir-frd
Copy link

Problem description

The Toolbar collapses icons into a 3 dots button (before and after).
This behavior confuses users.
Also, in some cases, the figure is big enough to accommodate all icons but the collapse still occurs.

Feature description

A boolean property to disable the collapse feature of the Toolbar.
For example:
Toolbar.collapse = True/False

Potential alternatives

Set a number for "must show" icons.
For Example:
Toolbar.number_of_icons = int

Additional information

No response

@mattpap
Copy link
Contributor

mattpap commented Oct 13, 2022

Also, in some cases, the figure is big enough to accommodate all icons but the collapse still occurs.

This looks like a bug. I would recommend trying out bokeh 3.0-rc if you can. There were a lot of changes, fixes and other improvements to toolbars in this release, so it's likely already fixed. Otherwise please submit a minimal reproducible example for us to reproduce this, and the version of bokeh you use.

@mattpap
Copy link
Contributor

mattpap commented Oct 13, 2022

Toolbar.number_of_icons = int

In bokeh 3.1 there will be support for customizable tool buttons, see #8153.

@ofir-frd
Copy link
Author

Thank you @mattpap !
I will take a look into bokeh 3.0-rc.

@davidforel
Copy link

@ofir-frd - If I retain the bokeh logo, the collapse does not happen. I, too, do not like the collapse, and I think it would be confusing for users of my app.

@bryevdv
Copy link
Member

bryevdv commented Nov 7, 2023

@davidforel there's not really any information to go on in your statement, e.g. are you talking about recent versions of Bokeh, or the versions from when this relatively old issue was opened? Did you attempt to try the Toolbar.number_of_icons described above? What are the specific circumstances that trigger a collapse? Do you have a MRE that can be run for investigation? Does this happen in all browsers or just one? What I would strongly suggest is to open a brand-new bug-report [1] issue with all the information requested in the new issue template. Link to this discussion, which we would then close in favor or a detailed issue.

[1] Assuming you see the issue described above by @mattpap still occurring (in latest releases), or if the number_of_icons property does not work as expected (in latest releases).

@bryevdv
Copy link
Member

bryevdv commented Nov 7, 2023

Adding NEEDS MORE INFO here in any case. There is nothing we can do with this issue as it stands, and I will close it soon regardless if it does not become more actionable (or replaced by a newer detailed issue)

@davidforel
Copy link

davidforel commented Nov 7, 2023

@bryevdv - You are quick! Well, I am a noob, so I can't give you everything you want [ MRE = Meals Ready to Eat ? ]. Bokeh version is 3.3.0, browser is Firefox, OpSys is WIn10. I am writing about Ofir's post in [ https://discourse.bokeh.org/t/toolbar-button-collapse-on-small-figure-size/9611 ] here because this seems to be the follow-up page. I am not concerned with the size of my plot forcing the toolbar collapse (my plot is pretty good size), just the fact that the collapse occurred at all. As @ofir-frd wrote on the referenced page, I would like to set a flag so the collapse cannot happen. I don't think it is cool that I would have to specify the number of tools to avoid toolbar collapse. Thank you for your patience.

@bryevdv
Copy link
Member

bryevdv commented Nov 11, 2023

Hi @davidforel MRE stands for Minimal Reproducible Example i.e. code we can take and run, without any modification, to reproduce what you are seeing, to make sure everyone is actually on the same page.

@bryevdv
Copy link
Member

bryevdv commented Dec 7, 2023

@davidforel @ofir-frd we do need a complete script to reproduce the issue, as well as any instructions that go along to make the problem show up. Otherwise, this will have to be closed as norepro

@bryevdv
Copy link
Member

bryevdv commented Dec 24, 2023

@mattpap what do you want to do with this issue? There's not code given here or in the Discourse issue, so I am inclined to close it.

@mattpap
Copy link
Contributor

mattpap commented Dec 24, 2023

There are issues with the current approach, which I'm addressing in PR #13571. I also plan to add support for a variant of a multi-line toolbar (either add support for wrapping or grid tool button layout or both).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants