Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Choices.js for Select #12002

Closed
bryevdv opened this issue Feb 14, 2022 · 4 comments
Closed

Investigate Choices.js for Select #12002

bryevdv opened this issue Feb 14, 2022 · 4 comments

Comments

@bryevdv
Copy link
Member

bryevdv commented Feb 14, 2022

As long as we are already bringing in choices.js as a dependency, I think we could consider switching to using their Single / Multi Select widgets (scroll down the page to see):

https://choices-js.github.io/Choices/

They are definitely more modern/nicer looking, and support asked-for features like better search and remote fetch for options, out of the box.

cc @bokeh/dev

@philippjfr
Copy link
Contributor

I agree, if we're already pulling in the dependency we may as well leverage all the nice features it provides.

@mattpap
Copy link
Contributor

mattpap commented Feb 16, 2022

I would keep native widgets and move them to a separate bundle.

@bryevdv
Copy link
Member Author

bryevdv commented Feb 18, 2022

@mattpap Not sure I understand the proposal, are you saying you'd have Select and a separate FancySelect? I am 👎 on that, I think we should be opinionated here and offer the best UX we are capable of offering as the default.

@g-parki g-parki changed the title Investiate Choices.js for Select Investigate Choices.js for Select Mar 9, 2022
@mattpap
Copy link
Contributor

mattpap commented Dec 6, 2023

I will close this given that we will be dropping external widget dependencies in near future (see e.g. PR #13551). I will implement new Select widget using generalized PaletteSelect's logic.

@mattpap mattpap closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants