Replies: 6 comments 4 replies
-
@bokeh/core I would actually like to change the default branch back to
|
Beta Was this translation helpful? Give feedback.
-
There should be no confusion where to put new changes, right now it's A good example is PR #12538, which fixes a problem with a dependency, which otherwise would make adoption harder for some users. The point is not to develop bokeh 3.0 further. All development efforts should be focused on 3.1 and possibly beyond. There should be no plan for I think there's quite a bit of confusion related to what minor and patch releases are about, probably from the old days of I would like to switch to a higher cadence release schedule, with an actual schedule, like every 2 months, with 6 weeks of development time before an RC and then 2 weeks for testing/documentation/release. Anything that wasn't finished in time, is moved to the next cycle without regrets, because we know there will be another one soon. A few quick notes:
No, everyone should contribute to
New contributors have almost no business contributing to 3.0. Unless they fix critical issues with 3.0, all their contributions should land on
Ian has almost no business to contribute to 3.0 anymore. An exception is working on critical regressions related to WebGL and color mapping or color bars. I'm not sure about Timo. Improvements to documentation contents, specifically related to 3.0, any clarifications, etc., should indeed be added to 3.0. However, general development of documentation should be viewed similarly to development and done for 3.1.
The mixture of back and forward ports, as has been done so far, is chaos in my view. Based on what I wrote so far, it should be clear that I expect porting between version should be minimized. Additionally forward ports should be a rare event, either a fix to a previous version was merged to that version's branch to e.g. expedite the release of a new patch version of bokeh, or there was something useful developed when patching an older version, which could be useful in the current branch. |
Beta Was this translation helpful? Give feedback.
-
@mattpap the fact that there are differences of opinion does not constitute confusion on other's part. You are issuing edicts for things that have not been decided or agreed upon. Point releases are used by many projects for ongoing bugfixing, and not merely for hotfixes which seems to be your position. I have specific goals and reasons for those goals that more frequent point releases would support. This will have to be a discussion.
Also worth reminding: everyone gets to choose themselves, where to devote their own personal time. My own position was stated more than a year ago and is more or less unchanged: #11280 (comment) Which I asked for feedback/discussion of at the time (but did not receive). Summarizing:
And overriding reason forth is to have smaller, less risky release on a shorter, more predictable schedule. Offhand, I would say roughly every ~8 weeks. This is for a few reasons:
So what are the options for that?
Do you have other ideas compatible with a faster release cadence? If not do you want to simply issue more, smaller minor releases (~6x/year)? It's not my first preference but I would consider it. But we need to develop discipline around regular releases, one way or the other. The lumpy unpredictable "sometimes release cycles take a year" schedule is not something I want to continue. As for specific points:
For instance I disagree with this entirely. New contributor's contributions are typically small and low risk, and they should go in a release ASAP in order to afford a positive feedback cycle to them (hopefully encouraging more contributions). Poinr releases are perfect for most new contributor contributions. We've also both had the experience of seeing a new issue come up and fixing it immediately because ten minutes can clear it off the tracker. Those are also great candidates of ongoing point bugfix releases. The reporter also gets a positive experience with the project when their fix goes in very soon.
I don't disagree, which is in fact why I want to try to focus of forward ports. Forward ports are unavoidable when there is a point release (the SRIs and changelog at least need to be brought forward). There will almost aways need to be some point release, even under your stricter preferences. Therefore I would like forward ports to be the practiced norm and back-ports be the exception, or ideally avoided altogether. It's also trivial to get the relevant list of commits to consider via git query when forward porting, there is much more room for confusion or error in the other direction. cc @bokeh/core |
Beta Was this translation helpful? Give feedback.
-
I wanted to chime in with some high-level comments. I'm not particular concerned with the details of the versioning and release plans, as a relative newcomer to Bokeh core I can work within whatever constraints are agreed. But I would very much like information like this to be clearly documented and easily available. As someone who works a little on a number of different OSS projects, each of which has different protocols and rules, it is very helpful if I can easily and quickly look up the current process and apply it correctly. Otherwise I end up remembering or guessing what the protocol is and accidentally applying that of project X to project Y. I expect this will help all contributors, particular new ones which are the ones I am most interested in helping. Secondly, in situations where there is disagreement we should resort to a vote. We are a democracy, and every core contributors vote carries the same weight regardless of longevity and perceived contribution and commitment to the project. |
Beta Was this translation helpful? Give feedback.
-
I guess this has fizzled out, so I am just going to state my intentions, which are:
That still allows for advancing the default branch "sooner" rather than "later" and also adheres to the timeline of BEP 6. Hopefully that is a compromise everyone can live with. Otherwise if there are objections, then we should simply put things to a vote. |
Beta Was this translation helpful? Give feedback.
-
Specifically, BEP 6 states this:
I would resolve this disagreement by amending to:
|
Beta Was this translation helpful? Give feedback.
-
I noticed the default branch has been moved to
branch-3.1
. While I agree that there should be abranch-3.1
made at this time, I am not sure I agree that it should become the default so soon, given that there will definitely be more releases onbranch-3.0
in the near future. @mattpap I assume this was you? In the future can we agree to have anyone open a GH Discussion prior to changing the default branch, in order to give everyone else a heads up (at least a day, say) and an opportunity to comment?Beta Was this translation helpful? Give feedback.
All reactions