Replies: 3 comments 1 reply
-
This is a valid development approach under given circumstances, however not applicable here. All your individual PRs have to be reviewed anyway. I would rather you focused on quality of individual changes, which would reduce my review burden and, in result, improve the turnaround time. I will definitely not review and merge one big PR. In fact I would reject it solely on principle. |
Beta Was this translation helpful? Give feedback.
-
Perhaps I can rephrase the idea for extra clarity. The underlying problem is the requirement to provide both
Providing one or the other is easy, but both at the same time is more difficult. The proposal here aims to provide both. The expectation is that there will still be the same number of functional PRs, but they will be against the Of course the final merge of |
Beta Was this translation helpful? Give feedback.
-
I just want to reiterate that my understanding is that this is not about reviewing one big PR. Subject to individual changesets still being reviewable in isolation (always a requirement), I actually think different people work differently, and we should step out of the way and allow for contributors adopt whatever process best fits their individual circumstances or preferences with the least friction for them. |
Beta Was this translation helpful? Give feedback.
-
I propose that the remaining LaTeX work is done on a separate branch rather
branch 3-0
. When all the work is done, the whole branch can be merged to stable branch after squashing. The PR structure would look something like this:This solves the problems of:
The idea is to have the feature PRs only containing the code changes.
All updates to baselines files will be done only once on the LaTeX main branch when it's ready to be merged into
branch 3-0
.Beta Was this translation helpful? Give feedback.
All reactions