Make ESLint part of test:codebase #11305
tcmetzger
started this conversation in
Build / CI
Replies: 1 comment
-
Linting is very slow, so this would negatively affect overall development experience. Given this idea is targeted towards newbies, I would actually enable linting in |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
While talking about #11304, @bryevdv and I were wondering if it would make it easier for local development and testing to have ESLint included when calling
node make test:codebase
ornode make test
. To have linting included with codebase tests might make things more consistent for new contributors who might expect linting to be part of codebase testing (and include that in a pre-push git hook, for example). A possible downside would be that this might increase the CI's run time.Beta Was this translation helpful? Give feedback.
All reactions