Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure directory exists log message ( and directory setting in registry on harvest all ) #27

Open
sdm7g opened this issue Feb 7, 2019 · 1 comment

Comments

@sdm7g
Copy link

sdm7g commented Feb 7, 2019

Log message from
https://github.com/bloomonkey/oai-harvest/blob/develop/oaiharvest/harvest.py#L211
logger.debug("Creating target directory {0}".format(self._dir))
would make more sense as:
logger.debug("Creating target directory {0}".format(os.path.dirname))
It is logging the top level directory and not the directory it is actually creating.

Also note that when using a directory setting in the registry, and doing a harvest "all" , all of the files from all providers go into the directory from the first provider chosen. Not sure that anything can be done about that other than documenting that is the case, or perhaps it would be less confusing just to take directory out of the registry. Since the directory setting is per invocation rather than per provider, it would make more sense to restrict it to the command line and not have registry values that are ignored.

@bloomonkey
Copy link
Owner

Yes, that would be more accurate as a log message.

The second of these issues certainly sounds like a bug - I've move it to a separate issue #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants