Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 parser chokes when const modifier describes a constructor function #2825

Closed
1 task done
ahrjarrett opened this issue May 12, 2024 · 0 comments 路 Fixed by #2868
Closed
1 task done

馃悰 parser chokes when const modifier describes a constructor function #2825

ahrjarrett opened this issue May 12, 2024 · 0 comments 路 Fixed by #2868
Assignees
Labels
A-Parser Area: parser L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@ahrjarrett
Copy link

ahrjarrett commented May 12, 2024

Environment information

CLI:
  Version:                      1.7.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.9.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

Hopefully the playground repro + biome rage + issue title is descriptive enough, but let me know if you'd like me to talk through anything! :)

Expected result

Parser understands that new in a type signature is a method, and allows type parameters to be declared with the const modifier

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug labels May 13, 2024
@Conaclos Conaclos self-assigned this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Parser Area: parser L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants