Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃搸 Implement declaration-block-no-shorthand-property-overrides #2807

Open
Tracked by #2511
togami2864 opened this issue May 10, 2024 · 4 comments 路 May be fixed by #2958
Open
Tracked by #2511

馃搸 Implement declaration-block-no-shorthand-property-overrides #2807

togami2864 opened this issue May 10, 2024 · 4 comments 路 May be fixed by #2958
Assignees
Labels
A-Analyzer Area: analyzer A-Linter Area: linter L-CSS Language: CSS S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@togami2864
Copy link
Contributor

togami2864 commented May 10, 2024

Description

Implement declaration-block-no-shorthand-property-overrides

Important

  • Please skip implementing options for now since we will evaluate users actually want them later.
  • Please ignore handling extended CSS language cases such as sass and less.
  • Please skip custom function since we haven't syntax model yet.

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

@togami2864 togami2864 added S-Help-wanted Status: you're familiar with the code base and want to help the project A-Linter Area: linter L-CSS Language: CSS A-Analyzer Area: analyzer labels May 10, 2024
@neokidev
Copy link
Contributor

Hello! I'm interested in tackling this issue.

@ematipico
Copy link
Member

We should come up with a better name. The current name is very long. What do you suggest @togami2864 ?

@togami2864
Copy link
Contributor Author

How about noShorthandPropertyOverrides? I think it's fine not to include declaration-block since there's only one override rule.

@neokidev
Copy link
Contributor

neokidev commented May 21, 2024

I have some questions regarding the implementation:

Specification:

  • Should we skip handling vendor prefixes such as -webkit for now in this rule? It appears that we ignored them in the previously implemented noUnknownProperty rule.

Implementation:

  • For this rule, it would make the implementation easier if the run method of Rule trait could be executed with Ast<CssDeclarationBlock> as the query, allowing for multiple diagnostics to be set from there. Is this feasible in Biome? (Currently, I am proceeding with the implementation by specifying Ast<CssGenericProperty> as the query.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Analyzer Area: analyzer A-Linter Area: linter L-CSS Language: CSS S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants