🐛 formatOnSave does not respect formatter.ignore

[jrson83]

VS Code version

1.89.0

Extension version

2.2.2

Biome version

1.7.2

Operating system

• Windows
• macOS
• Linux

Description

This issue is identical to biomejs/biome-vscode#189 which has been fixed for files.ignore.

---

If 'format on save' is turned on, using formatter.ignore the Biome.js extension will format files that should be ignored.

// .vscode/settings.json
"settings": {
  "editor.formatOnSave": true
}

Using files.ignore the issue is fixed.

// biome.json
{
  "files": {
    "ignore": ["node_modules", "no-format.js"]
  }
}

Using formatter.ignore the issue still persists.

// biome.json
{
  "formatter": {
    "ignore": ["node_modules", "no-format.js"]
  }
}

Steps to reproduce

1. Clone the repo:

git clone https://github.com/jrson83/biome-ignore-issue.git
cd biome-ignore-issue
pnpm install

2. Open packages/core/src/no-format.js and save the file, you see it formats.

Expected behavior

1. Since the issue is identical to "editor.formatOnSave": true does not respect "files": { "ignore": ["example.ts"] },🐛  biome-vscode#189 which has been fixed for files.ignore, I expect the same behaviour using formatter.ignore.
2. If you run biome.js in the terminal, e.g. pnpm run format the files are NOT formatted.

Does this issue occur when using the CLI directly?

No

Logs

No response

[nhedger]

Moving this to the main repo, because it appears to be related to the LSP.

[ematipico]

Reproduction: https://github.com/vktrl/biome-vscode-ignore-bug

[ematipico]

The reproduction #2781 (comment) isn't valid, because it relies on nested biome.json files, which aren't supported.

@jrson83 can you provide a minimal reproduction?

[jrson83]

@ematipico see the actual issue above I already provided an example:

git clone https://github.com/jrson83/biome-ignore-issue.git
cd biome-ignore-issue
pnpm install

[ematipico]

Thank you