Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 overrides overrides extends overrides 馃槀 #2714

Open
1 task done
unional opened this issue May 4, 2024 · 0 comments
Open
1 task done

馃悰 overrides overrides extends overrides 馃槀 #2714

unional opened this issue May 4, 2024 · 0 comments

Comments

@unional
Copy link

unional commented May 4, 2024

Environment information

CLI:
  Version:                      1.7.2
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.10.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/9.0.6"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

// biome.json
{
  "extends": ["./some-config.json"],
  "overrides": [{...}]
}

/// some-config.json
{
  "overrides": [{...}, { "include": ["package.json"], "formatter": { "lineWidth": 20 } }]
}

The overrides in biome.json overrides overrides in some-config.json

specifically, I observe the package.json override does not work until I do:

// biome.json
{
  "extends": ["./some-config.json"],
  "overrides": [{...}, { "include": ["package.json"], "formatter": { "lineWidth": 20 } }]
}

Expected result

The overrides in biome.json concatenates overrides in some-config.json

Code of Conduct

  • I agree to follow Biome's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant