Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Image Not Found" in image preview is misleading #524

Open
Enet4 opened this issue Oct 11, 2021 · 0 comments
Open

"Image Not Found" in image preview is misleading #524

Enet4 opened this issue Oct 11, 2021 · 0 comments

Comments

@Enet4
Copy link
Collaborator

Enet4 commented Oct 11, 2021

When an error occurs while attempting to create a preview of the image, the web application will only report "Image Not Found".

Capture-dicoogle-image-not-found

However, there may be multiple reasons for why Dicoogle is unable to provide a quick preview (either via the thumbnail or by pressing the Show Image button).

  1. The image was indexed, but was no longer found in storage at the time of the preview
  2. The image is in an unsupported encoding, making Dicoogle unable to construct the preview

In case 1 the information would be OK, but in case 2 the message given to the end user is still "Image Not Found", which is very misleading (relevant question on learning pack: bioinformatics-ua/dicoogle-learning-pack#24).

Acceptance criteria:

  • At the server application, ensure that the image service returns different output to distinguish these two kinds of errors.
    • Preferably in a JSON object
  • At the webapp, use that information to show an image providing a more accurate error message
    • For instance, a failure like in case 2 should show something like "Could not create preview"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant