Prettier formatting commit hook requires installed node_modules #406
Labels
Comments
Enet4
added a commit
that referenced
this issue
Oct 6, 2023
We were not using these dependencies effectively, and was a burden when working on other parts of the repository (#406)
Enet4
added a commit
that referenced
this issue
Nov 6, 2023
We were not using these dependencies effectively, and was a burden when working on other parts of the repository (#406)
bastiao
pushed a commit
that referenced
this issue
Dec 1, 2023
* Update package locks - npm update - upgrade to v3 * [webcore] update package lock to v3 * [webapp] Update dependencies - npm update - upgrade lock file version to v3 * [webapp] Increase Node.js requirements - Node.js 16 - npm 7 * [webapp] Update more dev dependencies - babel-loader - eslint-webpack-plugin 4 - rimraf 5 - sass-loader 13 - webpack-cli 5 * [webapp] Remove husky and lint-staged We were not using these dependencies effectively, and was a burden when working on other parts of the repository (#406) * [webapp] Update @ungap/custom-elements * [webapp] npm update again * [webapp] Require dicoogle-client 5.2.5 - due to unexpected breaking change in v5.2.4 * Set webUI module media type to text/javascript * npm update * Update webapp dependencies again npm update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Users may be blocked from committing their code due to the husky pre-commit hook, as this one is provided via npm on the web app. Users who are not working on the web application are also required to call
npm installthere regardless.This should be tweaked to allow for the hook to skip the formatting step if husky is not available.
The text was updated successfully, but these errors were encountered: